search

nicford / Movilytics

Welcome to our website Movylitics, a Sophisticated GroupLens dataset and tmdb analytics exploration tool.
BSD 3-Clause "New" or "Revised" License
3 stars 3 forks source link

Nx issues for frontend #3

Closed nicford closed 3 years ago

nicford commented 3 years ago

Frontend was not created using nx and is therefore not in nx.json and angular.json. Also, frontend is using tslint, which is deprecated. All this will probably affect testing too.

TODO: switch to eslint, add to angular.json, add to nx.json

nicford commented 3 years ago

create New Ionic app using nxtend nx plugin for ionic-angular. New app is empty and are waiting for @kjturan to migrate to it. Also, still tslint needs to upgraded to eslint, and some deprecated functions need to be updated

nicford commented 3 years ago

@SteveLim99 please look into migrating to eslint and removing the deprecated function used in the ucl-imdb project.

You can see these errors when running nx lint on the ucl-imdb project.

SteveLim99 commented 3 years ago

Will try to migrate tslint, additionally, i suggest that we remove ucl-imdb as a whole considering that it is already deprecated and replaced with ionic-imb

nicford commented 3 years ago

This should have been communicated better, but to solve this issue, ucl-imdb was recreated using nx. This removed the errors we previously had. Ionic-imdb will now be migrated to Ucl-imdb by @kjturan

SteveLim99 commented 3 years ago

Migrated tslint to eslint, problem has now been resolved. @kjturan please set up the eslint file with the rules you previously defined in the old tslint file

kjturan commented 3 years ago

i didnt set up any rules. cheers

On Thu, Mar 11, 2021 at 4:58 PM Zi Lian Lim @.***> wrote:

Migrated tslint to eslint, problem has now been resolved. @kjturan https://github.com/kjturan please set up the eslint file with the rules you previously defined in the old tslint file

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nicford/databases-group8/issues/3#issuecomment-796886848, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKQEWJH662WJWTEA4KPYATTTDDZC7ANCNFSM4YYF7XIA .