Refresh & update all the attributes, health check wait

nicgrayson / terraform-provider-marathon

a Terraform (http://terraform.io) provider for interacting with Marathon (https://mesosphere.github.io/marathon/)

MIT License

59 stars 24 forks source link

Refresh & update all the attributes, health check wait #18

Closed lamdor closed 9 years ago

lamdor commented 9 years ago

This will catch the other marathon_app attributes to refresh and make sure that they get updated if they differ from the configuration vs marathon.

lamdor commented 9 years ago

I haven't yet ran this against env-setup, so I hasn't been tested fully against our stack.

lamdor commented 9 years ago

also https://github.com/gambol99/go-marathon/pull/71

lamdor commented 9 years ago

I also have a fix locally for https://github.com/gambol99/go-marathon/pull/72 when it gets merged in.

lamdor commented 9 years ago

tested against env-setup. I need to add upgrade_strategys for all the apps that are missing it.

sherzberg commented 9 years ago

retest this please

lamdor commented 9 years ago

@sherzberg The marathon builds have been failing on jenkins for some time, but they've always passed locally. I chalk it up to the docker version mismatch between host and slave image.

knuckolls commented 9 years ago

Reviewed. Looks good to me. :+1: