search

nicgrayson / terraform-provider-marathon

a Terraform (http://terraform.io) provider for interacting with Marathon (https://mesosphere.github.io/marathon/)
MIT License
59 stars 24 forks source link

Add support for networkName #46

Closed wleese closed 7 years ago

wleese commented 7 years ago

This is a bit limited at the moment, because we only need ipAddress{ networkName: "xx" }

Had to update go-marathon to get support for IPAddressPerTask

banno-autobot commented 7 years ago

Can one of the admins verify this patch?

DustinChaloupka commented 7 years ago

Would it be possible to add a test for this? This project hasn't been well maintained or tested, but would like to improve upon that aspect. Just something that checks this new field in each of the two functions it was added to.

wleese commented 7 years ago

Sadly make test wants to pull some Banno internal stuff, so it's hard for me to perform any tests.

I've added 2 tests that seemed to make sense to me. I've also renamed networkname to network_name to be more consistent with other parameters.

adamdecaf commented 7 years ago

Does the vendor update conflict with the vendor update we just did?

adamdecaf commented 7 years ago

ok to test

DustinChaloupka commented 7 years ago

@adamdecaf That PR you linked did not update the go-marathon vendor, just terraform related vendors.

adamdecaf commented 7 years ago

Gah. It's hard to tell on github. 👍

adamdecaf commented 7 years ago

I'm going to release a version with the vendor update and then this merged.

adamdecaf commented 7 years ago

retest this please