search

nicguzzo / wands

Apache License 2.0
7 stars 8 forks source link

Screen not registered for screen handler wands:wand_menu! #11

Closed robhawkes closed 3 years ago

robhawkes commented 3 years ago

Trying out the wands for the first time but currently unable to open the wand menu. Here are some details that'll hopefully help to debug it, and let me know if you need anything else from me.

Versions

Issue

crysthala commented 3 years ago

Having a similar problem, and a hell of a time trying to track it down. I'm doing the usual "dump the problematic mods in a clean profile, then remove mods until the thing works" procedure. Every time I think I've tracked it down, I'm unable to confirm it. I get the feeling it might be a bad interaction between several mods, not just 2. Somebody on the Curseforge page suggested it was BCLib, but I don't seem to have that installed, even as a jar-in-jar.

It's dangerous to bugtest alone! Here, take this latest.log. This is just me loading up, starting the world, pressing the key a few times, and exiting.

Mods: Minecraft 1.17.1, Fabric Loader 0.11.7, bundled Java runtime, Linux Mint 19.3. All the mods were downloaded from Curseforge, and I use the vanilla launcher. Mod file names for your version-checking pleasure:

I have to take a break now or I'm going to kill someone. Will try again later.

nicguzzo commented 3 years ago

I'm looking into this.

crysthala commented 3 years ago

Okay, I have removed each of these mods one by one to see what happens, and I've ruled out the following as potential culprits: Cloth Config API (at least the standalone file), Data Attributes, Carpet Mod, and Patchouli.

So we're left with Dawn API, Impersonate, Industrial Revolution, Megane, Mod Menu, Player Ability Lib, Pehkui, Somnus, Trinkets, and Yung's API. Architectury, Fabric API, Fabric Language Kotlin, and WTHIT also have to be in there as dependencies, but they don't break anything.

nicguzzo commented 3 years ago

I started with a fresh install on multimc, and adding mods one by one using the same versions, only when I added the trinkets mod this started to happen.

nicguzzo commented 3 years ago

it's weired, if I remove all the other mods but trinkets, Building Wands, and deps), then it works ok. it must be trinkets+other mod.

crysthala commented 3 years ago

Removing any one of the mods I listed fixes it for me, but I'm really at a loss as to why. I'm going through the .jars looking for access wideners and mixins they seem to share, since it's my understanding those are common culprits in compatibility issues.

crysthala commented 3 years ago

So. Many. Mixins. I should mention that I'm not 100% on the relevance of any of this, but it might be. I thought maybe something was interfering with how Architectury behaves, which then broke Wands code that relied on it. (And I find it kind of interesting how many mods are apparently tinkering with the same classes, anyway.) I'm not sure the following have any overlap with Wands or Architectury, but maybe I missed something: Dawn API, Megane, PAL, Yung's API.

However, a lot of these mods seem to mixin to some of the same classes as Architectury does.

So there's my entry in the "how many times can I say mixin in one post without really knowing if it matters at all" contest. :shrug: I hope it's helpful.

nicguzzo commented 3 years ago

something is preventing architectury to invoque ClientLifecycleEvent.CLIENT_SETUP.register(e->{}) on the client, in there is where I register the wand and palette screens.

nicguzzo commented 3 years ago

I've moved the registrations outside ClientLifecycleEvent.CLIENT_SETUP, this fixes it for now. I'll upload a new version asap for fabric, until I have time to test properly because this is likely to now work on forge,.

crysthala commented 3 years ago

The updated version works perfectly. Thanks for looking into this.