search

nichee / pe

0 stars 0 forks source link

Only singaporean ID's are allowed #11

Open nichee opened 4 months ago

nichee commented 4 months ago

image.png

Hospitals serve international patients as well, and it does not seem possible to add a patient without their ID.

This makes it impossible to add a foreign patient without a Singapore ID into the system without using a fake/filler ID

nus-pe-bot commented 4 months ago

Team's Response

This is a good catch and a valid concern that international patients will not have a singaporean NRIC. However, not only has this bug been reported before in issue #1435, we have included this as a feature extension in our DG. We have caveated that an expansion of parameter checkings will be inclusive to foreign patients and doctors. Please refer to the screenshot below in which we cite our DG that we recognised this as a limitation of our current app.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Target User not specified clearly

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

This app is extremely tailored to a singaporean hospital (Only singapore ID allowed), but the target user stated seems to be "Hospital clerks/administrators or anyone who manages the relevant stakeholders in a hospital setting"

A foreign hospital staff member would have to read quite far into the UG before they realise they can't use the app due to the ID problem

[original: nus-cs2103-AY2324S2/pe-interim#1174] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising this. Indeed, the current MediCLI system is tailored to the Singaporean setting, so we should have made it clearer at the start of the UG. However, we think this should be a low severity since it does not impact the use of our product itself. Furthermore, we have also noted in our DG that we aim to make the system more friendly to foreign hospital settings.

Screenshot 2024-04-20 at 3.45.03 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]