nichee / pe

0 stars 0 forks source link

Inconsistency between UG and DG for "find" function #17

Open nichee opened 4 months ago

nichee commented 4 months ago

image.png

image.png

First image is DG, second is UG.

DG only states valid input as "Keywords matching existing personsʼ names.", whereas UG lists all the requirements for input

nus-pe-script commented 4 months ago

Team's Response

Thank for raising this issue as this is a valid bug. However, as mentioned in issue 346 previously, this is a documentation bug on our part. This is because as can be seen from the command description, command format and the app error message itself, we intended for it to only search using keywords and not substring. As such this is a duplicate of issue 346 as fixing that bug in the user guide will fix this issue as well. (image attached below)

image.png

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding various duplicate names to the person leads to find command not listing down the patients names

image.png

Upon adding a couple of patients with the same name but different NRIC.

image.png using Da as the keyword for finding names.

I am met with listing of 0 persons.

image.png

This could be the user not knowing if the keyword means that it has to be "David" in this scenario, leading to a misinterpretation


[original: nus-cs2103-AY2324S2/pe-interim#460] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for raising this. We acknowledge this is an issue, however, this is just a typo in the user guide and not a functionality bug in our programme. The error message in the actual MediCLI system states that find: Finds all persons whose names contain any of the specified keywords (case-insensitive) and displays them as a list with index numbers. (Screenshot attached below). The line you referenced was a typo as the overall description of the command in the user guide also states that it only accepts keywords.

Screenshot:

Screenshot 2024-04-20 at 3.14.33 PM.png

Screenshot 2024-04-20 at 3.15.33 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]