nichee / pe

0 stars 0 forks source link

Unnecessarily complicated command format for Appt #4

Open nichee opened 4 months ago

nichee commented 4 months ago

"addappt ad/2024-06-09 10:15 dn/S1234567B pn/S1234567A" could be addappt ad/2024-06-09 10:15 dn/INDEX pn/INDEX

nus-se-script commented 4 months ago

Team's Response

Thank you for raising this. The structure of our commands is something our group has put much thought into. After another round of consideration, we still feel that our command structure is more suitable for our use case than the alternative you proposed. Although simpler, your proposed idea has one major flaw. Since the persons list is dynamic (add, delete, and query commands can change the index of each doctor and patient), the index would not be a unique identifier to a patient or doctor.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not agree that the index is not a unique identifier - even if the list is dynamic, at the given moment that the addappt command is called, index IS a unique indentifier. I understand the concerns, however the reasoning as to why the idea is flawed is incorrect - in fact I've seen multiple groups(as well as my own) effectively use index as a unique identifier to a patient or doctor.

I'm sure there are other reasons why your group believes the current command structure is more suitable, however it is not stated.

I'd argue that this should be a response.notInScope