search

nichee / pe

0 stars 0 forks source link

App does not account for small typo in format #8

Open nichee opened 4 months ago

nichee commented 4 months ago

image.png When time is inputted as "23.40" instead of "23:40", App rejects the input

nus-pe-bot commented 4 months ago

Team's Response

Both the error message and the user guide explicitly states the input should be "yyyy-MM-dd HH:mm". The MediCLI product is designed to be used as specified in the user guide and internal error messages. Furthermore, our addappt command is already lenient of small typos. For example, for the date-time field, extra white space between the date and the time will be ignored (because we understand for fast typing clerks, extra space is an easy mistake). However, the mistake being reported is not a very likely typo by a skilled typer (the intended audience of the 2103 project). Thus we don't think this is a valid bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

Hi there, I do not agree that this specific typo is "not very likely" since the user is a "skilled typer". Being a skilled typer is a completely separate issue from the user's familiarity with the command format. I would argue that it is much more natural and the standard way to type times as "23.40" instead of "23:40". When you type a time when texting on your phone do you type "9.40" or "9:40"?

I think the other points about the command being lenient with whitespace is great for the app! But it is not directly relevant to this bug report. I also understand that the error message and user guide prompt the user for the intended format, however this does not respond to the bug report.

The spirit of the bug report is that the app can be improved in this small way, which I think is undeniable. Perhaps response.notInScope would have been more appropriate?