nicho92 / MtgDesktopCompanion

Cards manager for magic the gathering
Apache License 2.0
155 stars 34 forks source link

Card art versions #200

Closed Arkewas closed 1 month ago

Arkewas commented 2 years ago

Configuration

Describe the bug Hello, I have downloaded MTG card pictures from https://mega.nz/folder/4gIQTabQ#PFrnkeYbRmlrgf2swxWz1Q I have put them in subfolders for each set but for the cards with different card arts only the original art is shown. For example the Acclaimed Contender card (Throne of Eldraine expansion); the jpg files are properly named Acclaimed Contender1.fullborder.jpg and Acclaimed Contender2.fullborder.jpg but the alternate card image is the same as the original one as you can see from the attached screenshot. The same issue occurs with all cards with different card arts. Am I missing something? Best regards

Screenshots MTG Companion issue with different card arts

nicho92 commented 2 years ago

I fixed for next release. but all case are not covered If you have a naming convention somewhere....( with all altered card name - borderless, showcase, extended ARt, ....).

Arkewas commented 2 years ago

Thank you for fixing that but do you mean I have to rename the alternate jpg files differently from (Card name)2.fullborder.jpg ? If this is the case, which is the exact naming convention to match MTG Companion database for Alternate Art, Extended Art, Showcase, Borderless etc. ? In the above example the 2nd cart art for Acclaimed Contender is Extended Art; I have renamed the file as Acclaimed Contender (Extended Art).fullborder.jpg but it still doesn't work.

Best regards

nicho92 commented 2 years ago

You don't have to rename them don't worry :p The app will check it by itself.

I did this quick fix but I think it's not optimized. i have no detail of naming convention if there are "Showcase" , " extended art " and normal card in the same set.

On Sun, Dec 19, 2021 at 10:11 PM Arkewas @.***> wrote:

Thank you for fixing that but do you mean I have to rename the alternate jpg files differently from (Card name)2.fullborder.jpg ? If this is the case, which is the exact naming convention to match MTG Companion database for Alternate Art, Extended Art, Showcase, Borderless etc. ? In the above example the 2nd cart art for Acclaimed Contender is Extended Art; I have renamed the file as Acclaimed Contender (Extended Art).fullborder.jpg but it still doesn't work.

Best regards

— Reply to this email directly, view it on GitHub https://github.com/nicho92/MtgDesktopCompanion/issues/200#issuecomment-997461963, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACXZPH3H23JINRAXEMFI2NDURZDB3ANCNFSM5JJ7JYUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

Arkewas commented 2 years ago

Thank you for the clarification; I'm eager to test 2.29 version. Can you tell me when it will be released approximately?

Best regards

nicho92 commented 2 years ago

maybe at end of january. Otherwise, you can compile the source from git with maven

Arkewas commented 2 years ago

Very well, I'll wait for the official 2.29 release

Best regards