search

nicholas-fr / test-content-validation

CTA WAVE Test Content Validation
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Enhancements #1

Closed Lis-TV closed 2 years ago

Lis-TV commented 2 years ago
  1. Propose either add information that it is supported on Windows only, or update implementation to be possible to run on Linux.
  2. Please add information that libxml is also needed.
  3. It is worth to clarify the -v folder. For example 'folder containing t1 to t34 subfolders'
Lis-TV commented 2 years ago

Propose also make -m optional. If the parameter is skipped, then application shout perform wget to https://docs.google.com/spreadsheets/d/1hxbqBdJEEdVIDEkpjZ8f5kvbat_9VGxwFP77AXA_0Ao/export?format=csv

nicholas-fr commented 2 years ago

Thanks for these proposals.

  1. Propose either add information that it is supported on Windows only, or update implementation to be possible to run on Linux.

It was intended to work on both Windows and Linux. Following the updates made by Romain, it's confirmed to be now working on Linux as well.

  1. Please add information that libxml is also needed.

Added to the README and added requirements.txt.

  1. It is worth to clarify the -v folder. For example 'folder containing t1 to t34 subfolders'

Added clarification to the help text: "Folder containing subfolders with sets of test vectors for a specific codec e.g. "cfhd_sets", that contain subfolders for each frame rate family e.g. "15_30_60", that contain subfolders t1 .. tN with the test vectors to validate. Example of path to test vector MPD: /cfhd_sets/15_30_60/t1/2022-09-23/stream.mpd"

Note that the issues you've had running the tool are mostly due to outdated test vectors, that use an old folder/file structure. The current agreed structure was discussed here and is:

_sets/// Example: https://dash.akamaized.net/WAVE/vectors/cfhd_sets/12.5_25_50/t1/2022-07-20/ > Propose also make -m optional. If the parameter is skipped, then application shout perform wget to https://docs.google.com/spreadsheets/d/1hxbqBdJEEdVIDEkpjZ8f5kvbat_9VGxwFP77AXA_0Ao/export?format=csv Done (using urllib so it should work on both Windows and Linux).
nicholas-fr commented 2 years ago

Thanks for sharing these proposals, I believe these points have been addressed. If you have further feedback, please feel free to reopen or to create a new issue.