nicholas-fr / test-content-validation

CTA WAVE Test Content Validation
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

parameter_sets_in_band_present - incorrect failure #11

Open Lis-TV opened 1 year ago

Lis-TV commented 1 year ago

The SequenceParameterSet is present in sample NALU.

nicholas-fr commented 1 year ago

As with #12, I'm not sure what is causing this issue as I have been unable to reproduce it unfortunately.

I have added a debug feature to the script. If you still see this or a similar issue with the latest version of the script, please would you run the script with the --debug option, and share the tcval_logs_date_time.zip that is created, so that I can check how the script may be misinterpreting the ffmpeg/MP4Box logs.

Lis-TV commented 1 year ago

The output JSON file has: _"test_stream_id": "2", "test_file_path": "../dpctf-deploy/content/cfhd_sets/12.5_25_50/t2/2022-10-17", "parameter_sets_in_band_present": { "expected": true, "detected": false, "testresult": "fail" }, But when I am running _cd ../dpctf-deploy/content/cfhd_sets/12.5_25_50/t2/2022-10-17/1/ cat init.mp4 > a.mp4 cat 0.m4s >> a.mp4 MP4Box -dxml --analyze=bs a.mp4 cat adump.xml | grep SequenceParameterSet

I have 5 entities of

NALU size="30" code="7" type="SequenceParameterSet"

So seems the parameter_sets_in_band_present is set incorrectly.

nicholas-fr commented 1 year ago

Expected to be the same issue as #12, so if you would please share the JSON results and debug zip (please run the script with --debug), I should be able to find where the parsing of the ffmpeg/MP4Box output is going wrong. Thanks.

Lis-TV commented 1 year ago

The origin of this issue is different then origin of #12, "analyze=bs" option is not used in MP4Box to check any of: parameter_sets_in_band_present, picture_timing_sei_present, vui_timing_present

gitwjr commented 1 year ago

@nicholas-fr Not blocking release but the validation tool needs updating. Nicholas will review and comment.