nicholas-leonard / dp

A deep learning library for streamlining research and development using the Torch7 distribution.
Other
343 stars 140 forks source link

BaseSet does not actually accept table of Views as input #132

Open deet opened 9 years ago

deet commented 9 years ago

The documentation of BaseSet's says that inputs can be a table of Views, but that triggers the assertion here:

https://github.com/nicholas-leonard/dp/blob/616aec279b2e8fbdb8fd9f12825501545ccc3b17/data/baseset.lua#L49

It seems as though we need to manually create the dp.ListView before passing it to BaseSet.

(Forgive me if I'm wrong, I'm new to Lua and this library.)