nicholas-leonard / dp

A deep learning library for streamlining research and development using the Torch7 distribution.
Other
343 stars 139 forks source link

Recurrent language model example crashes with `--softmaxtree` #151

Closed ghost closed 9 years ago

ghost commented 9 years ago

To replicate, run for example th recurrentlanguagemodel.lua --softmaxtree, which goes down in flames with ../rnn/SequencerCriterion.lua:44: SequencerCriterion only decorates stateless criterions.

nicholas-leonard commented 9 years ago

Yeah @jekbradbury brought this up via gitter. I fixed it but somehow didn't merge upstream. luarocks install rnn should fix it.

ghost commented 9 years ago

Thank you, now instead it is going down with rnn/SequencerCriterion.lua:42: attempt to call field 'recursiveAdd' (a nil value). I am assuming that this is due to some Rocks versions being out of sync and have tried to update both rnn and dp, but it still fails. Is there any way to update all installed Rocks?

nicholas-leonard commented 9 years ago

Yeah, nn. luarocks install nn.

ghost commented 9 years ago

Wonderful! Things are now working as intended!