search

nicholas-maltbie / OpenKCC

Open Source Kinematic Character Controller for Unity
http://nickmaltbie.com/OpenKCC/
MIT License
642 stars 60 forks source link

werd speld rong #190

Closed treesgobark closed 1 year ago

treesgobark commented 1 year ago

Description

Please include a summary of the change and which issue is fixed or what was added to the project.

added the letter 'i' to fix a grammatical error

nicholas-maltbie commented 1 year ago

Hi @treesgobark, thanks for looking over the code. You're right, most of those checkboxes only make sense for code changes. I’ll adjust the PR template to reflect that and have the checklist commented out by default or with a note that says to skip if not applicable when I’m off work today.

Changes look good. Remove the other two necessary sections in the description “How Has This Been Tested?” and “Checklist” and I’ll merge the PR later today.

nicholas-maltbie commented 1 year ago

Hey @treesgobark , looks like the PR checks are failing because there is no configured UNITY_LICENSE secret in your repo. I know the doc changes are alright because it's a fairly small change. I haven't tested merging in new changes from forked/external repos, I think it checks your repo for secrets instead of mine (which makes sense for security).

Here is the other change with the simplified pull request template - PR #191 I also created issue #192 for tracking setting up instructions on configuring the UNITY_LICENSE secret.

If you have any other questions or comments let me know! thanks for helping contribute to the project.