nicholas-maltbie / PropHunt-Mirror

PropHunt project made using Unity and Mirror Networking

MIT License

5 stars 1 forks source link

Object Hit Sounds #38

Closed nicholas-maltbie closed 3 years ago

nicholas-maltbie commented 3 years ago

Description

Added sounds for when objects (such as glass bottles) hit things in the scene.

How Has This Been Tested?

This has been tested through adding this script to an object and verifying proper creation of sound events when object moves based on settings.

Additionally unit tests have been created to fully cover the added liens of code.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

github-actions[bot] commented 3 years ago

Test Coverage Results for editmode: Line Coverage: 100% Link to run results: https://github.com/nicholas-maltbie/PropHunt-Mirror/actions/runs/815513598

github-actions[bot] commented 3 years ago

Test Coverage Results for playmode: Line Coverage: 28.9% Link to run results: https://github.com/nicholas-maltbie/PropHunt-Mirror/actions/runs/815513598

github-actions[bot] commented 3 years ago

Test Coverage Results for playmode: Line Coverage: 28.7% Link to run results: https://github.com/nicholas-maltbie/PropHunt-Mirror/actions/runs/818574284

github-actions[bot] commented 3 years ago

Test Coverage Results for editmode: Line Coverage: 100% Link to run results: https://github.com/nicholas-maltbie/PropHunt-Mirror/actions/runs/819074734

github-actions[bot] commented 3 years ago

Test Coverage Results for playmode: Line Coverage: 28.7% Link to run results: https://github.com/nicholas-maltbie/PropHunt-Mirror/actions/runs/819074734