search

nicholaschiang / hammock

Move your newsletters outside of your inbox. Focus on and learn from the content you love in a distraction-free reading space.
https://readhammock.com
GNU Affero General Public License v3.0
11 stars 1 forks source link

feat(article): add highlight deletion #109

Closed nicholaschiang closed 3 years ago

linear[bot] commented 3 years ago
PD-106 Allow for deletion of highlights

Deleting highlights will prove to be a bit of a hassle actually because of a bug I found (and fixed) earlier: > I'm fixing some issues where my XPath selectors are selecting based on the highlighted HTML (which is obviously different than the non-highlighted HTML because I have to add `` tags to style the highlights differently) while my parsing is based off of the un-highlighted HTML. One way to work around this issue is to leave the `` tags there for deleted highlights but just make them unstyled. That way, the XPath selectors are the same (they can still include `` tags in their paths) but the highlights will no longer show up for the end user. This is probably not the *best* way to go about doing it but it'll definitely be faster than trying to figure out how to un-compensate for deleted highlights.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hammock – ./

🔍 Inspect: https://vercel.com/readhammock/hammock/8rLGTLX4pUDkSyu3RYugpR9GFZa5
✅ Preview: https://hammock-git-pd-106-readhammock.vercel.app