search

nicholaschiang / hammock

Move your newsletters outside of your inbox. Focus on and learn from the content you love in a distraction-free reading space.
https://readhammock.com
GNU Affero General Public License v3.0
11 stars 1 forks source link

feat: add note taking dialog #142

Open nicholaschiang opened 3 years ago

nicholaschiang commented 3 years ago

Fixes PD-105

linear[bot] commented 3 years ago
PD-105 Build notes feature set

Users should be able to: * Make a selection. * Click on the "notes" icon button in the dialog that opens. * Type in a short note in the text box that appears to the right of the newsletter text (if on mobile, this text box dialog will take up the entire screen most likely or be a bottom drawer). * Save that note and have it appear next to the newsletter text (or at least some indicator that it's there so that the user can click on it again to edit/delete their note). The Notion and Roam integrations will be in a separate issue. This is just the basic MVP spec.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hammock – ./

🔍 Inspect: https://vercel.com/readhammock/hammock/GkKeD34dujDunwChsksTjYR5GQWc
✅ Preview: https://hammock-git-notes-readhammock.vercel.app

[Deployment for 9361a70 failed]

codecov[bot] commented 3 years ago

Codecov Report

Merging #142 (4a3de50) into develop (992f39f) will decrease coverage by 0.36%. The diff coverage is 0.00%.

:exclamation: Current head 4a3de50 differs from pull request most recent head 9361a70. Consider uploading reports for the commit 9361a70 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #142      +/-   ##
===========================================
- Coverage    34.96%   34.60%   -0.37%     
===========================================
  Files           84       85       +1     
  Lines         1427     1442      +15     
  Branches       429      434       +5     
===========================================
  Hits           499      499              
- Misses         928      943      +15
Impacted Files Coverage Δ
components/article.tsx 0.00% <0.00%> (ø)
pages/messages/[id].tsx 0.00% <ø> (ø)
components/icons/note.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 992f39f...9361a70. Read the comment docs.