search

nicholaschiang / hammock

Move your newsletters outside of your inbox. Focus on and learn from the content you love in a distraction-free reading space.
https://readhammock.com
GNU Affero General Public License v3.0
11 stars 1 forks source link

feat: replace `gmail.modify` with `readonly` scope #144

Closed nicholaschiang closed 3 years ago

nicholaschiang commented 3 years ago

Closes PD-162

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hammock – ./

🔍 Inspect: https://vercel.com/readhammock/hammock/CtK7ohLemLbcKTUhUKZb8B17fxHp
✅ Preview: https://hammock-git-permissions-readhammock.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #144 (900f054) into develop (f3e675c) will increase coverage by 0.82%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #144      +/-   ##
===========================================
+ Coverage    33.85%   34.67%   +0.82%     
===========================================
  Files           89       88       -1     
  Lines         1465     1439      -26     
  Branches       437      433       -4     
===========================================
+ Hits           496      499       +3     
+ Misses         969      940      -29
Impacted Files Coverage Δ
lib/api/gmail/sync.ts 0.00% <0.00%> (ø)
lib/api/gmail/watch.ts 0.00% <0.00%> (ø)
lib/model/user.ts 3.84% <ø> (ø)
pages/api/account.ts 33.33% <ø> (+0.98%) :arrow_up:
pages/login.tsx 90.00% <ø> (ø)
pages/api/redirect.ts 29.16% <0.00%> (+12.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3e675c...900f054. Read the comment docs.

linear[bot] commented 3 years ago
PD-162 Remove "send" permission

Currently, when using the `gmail.modify` OAuth2 permission, the user gets a prompt that says: > Read, compose, and send emails from your Gmail account. This is not what we want. All Hammock needs access to is to be able to read and label your emails (labeling is required so we can retroactively move messages into the "Hammock" label and so that we can mark archived messages as "read" in Gmail).