search

nicholaschiang / hammock

Move your newsletters outside of your inbox. Focus on and learn from the content you love in a distraction-free reading space.
https://readhammock.com
GNU Affero General Public License v3.0
11 stars 1 forks source link

feat: optimize feedback dialog for mobile #145

Closed nicholaschiang closed 3 years ago

nicholaschiang commented 3 years ago

Fixes PD-161

linear[bot] commented 3 years ago
PD-161 Optimize feedback for mobile

Instead of being on the side, the feedback dialog should just be at the end of the newsletter (way at the bottom). WDYT of this design decision @martin @juraj? Related to [PD-24](https://linear.app/readhammock/issue/PD-24/feedback-to-writer) (which is working on desktop pretty well).

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hammock – ./

🔍 Inspect: https://vercel.com/readhammock/hammock/HLFeS1ykTeZRixivMA7jYMpRsjKQ
✅ Preview: https://hammock-git-feedback-readhammock.vercel.app

codecov[bot] commented 3 years ago

Codecov Report

Merging #145 (2e6db36) into develop (429d637) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #145   +/-   ##
========================================
  Coverage    34.67%   34.67%           
========================================
  Files           88       88           
  Lines         1439     1439           
  Branches       433      433           
========================================
  Hits           499      499           
  Misses         940      940
Impacted Files Coverage Δ
components/article.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 429d637...2e6db36. Read the comment docs.