search

nicholascioli / rbroadlink

A broadlink library written in Rust. Based on https://github.com/mjg59/python-broadlink
https://crates.io/crates/rbroadlink
MIT License
3 stars 5 forks source link

Add HVAC/Air Conditioner support #5

Closed manio closed 1 year ago

manio commented 1 year ago

Nicholas, This PR adds a support for the broadlink-based Air Conditioner. It also includes my PR https://github.com/nicholascioli/rbroadlink/pull/4 If you merge mentioned PR before, please hold on and I will rebase this on top of your main.

Also please don't squash during merge as I always trying to carefully make commits, so that it is later much better for review changes.

I can also add some README/examples later after you merge this...

manio commented 1 year ago

Pls give me a sec. I need to rebase it now after merging PR #4

manio commented 1 year ago

Done :)

nicholascioli commented 1 year ago

Could you rebase against the new checks?

manio commented 1 year ago

Sure, it is now rebased (I believe it was not necessary as your changed doesn't conflict with this code).

Please merge but don't squash if you're OK with this.

On my TODO list I still have:

  1. Make a changes in documentation/examples
  2. Adjust my code to the panic/expect changes that @Wazner has made I'll do it in another PR after you merge this...

btw. Could you please also do a cargo fmt on this whole project afterwards?

manio commented 1 year ago

Thank you very much! I'm glad we have this support now in :) It took about a week of my work/debugging/testing :) As i said - I'll prepare some fixes/documentation soon...

Please also think about the cargo fmt :)

nicholascioli commented 1 year ago

No problem! Thanks for adding more device support!

Please also think about the cargo fmt :)

Oh yeah, I completely forgot to set this as a git hook. Adding now.