search

nicholasdavidson / pybit

Python Build Integration Toolkit - a distributed cross platform AMQP based build system
17 stars 5 forks source link

PEP8 adjustments #105

Open mmulich opened 11 years ago

mmulich commented 11 years ago

Would anyone be opposed to a few PEP8 changes? I can make the changes and submit them no problem.

Most python IDEs are going to make these adjustments for the the author, which means spurious PEP8'ish adjustments will end up in future commits by people outside your group. I know that each time I've made a change, my less sophisticated editor, emacs, changes all the tabs to spaces. I realize this might sound petty, so feel free to shoot it down.

nicholasdavidson commented 11 years ago

Not at all, if you want to clean up code that's very welcome.

jamesbennet commented 11 years ago

We use Geany/Gedit, with tabs [only]. Though Nick uses Eclipse. PEP8 says Never mix tabs and spaces. While spaces are more popular (allegedly), we probably started using tabs as we were from a C++ background. But yes, feel free to clean the code up. We began the project as python novices and anything which helps it become more accessible to other python developers would be of benefit :)