nicholasdavidson / pybit

Python Build Integration Toolkit - a distributed cross platform AMQP based build system
17 stars 5 forks source link

nmu uploads broken. #122

Closed jamesbennet closed 11 years ago

jamesbennet commented 11 years ago

NMU uploads are broken. Looks like an escaping issue.

it puts in "1.3.18 nmu1" into the db instead of "1.3.18+nmu1".

"+" means a space in HTML. So seems like it wasnt encoded before being curled by the hook?

The malformed version string then made dpkg-compare-versions go bang.

jamesbennet commented 11 years ago

This has been fixed before by curling with --data-urlencode etc.... re issue #97 Seems the hook on our SVN was not updated. Fixing now.