build_environment setup not working from fresh

nicholasdavidson / pybit

Python Build Integration Toolkit - a distributed cross platform AMQP based build system

17 stars 5 forks source link

build_environment setup not working from fresh #129

Closed ghost closed 11 years ago

ghost commented 11 years ago

A fresh install does not serve jobs to clients. The pybit-web error log contains:

[Tue Feb 12 19:15:01 2013] [error] [client 127.0.0.1] build_environment = app.config['db'].get_build_env_id(job.packageinstance.build_env.id).name # Lookup and send build_environment name [Tue Feb 12 19:15:01 2013] [error] [client 127.0.0.1] AttributeError: 'NoneType' object has no attribute 'id'

jamesbennet commented 11 years ago

Fixed the issue with retry job in 6eede66bf7aa616a4cc510f8557e828e4f1d2acc, wasnt checking for null build_env before dereferencing it.

jamesbennet commented 11 years ago

Not fixed.

jamesbennet commented 11 years ago

Fixed now?