search

nicholasdavidson / pybit

Python Build Integration Toolkit - a distributed cross platform AMQP based build system
17 stars 5 forks source link

Clarify blacklist rule description #135

Open ghost opened 11 years ago

ghost commented 11 years ago

The current help text on the page to add a blacklist rule is unclear. It gives the impression that it is possible to blacklist binary packages (libfoo-dev), not only source packages (foo). Binary packages can be omitted via specific commands to sbuild but these commands are not currently supported. (This would use the -N option to debhelper but this undermines the reproducibiility of builds and is not recommended. It is a supported technique when patched into debian/rules for bootstrapping purposes but is not advisable for standard builds.) The blacklist support in pybit only applies to source packages, i.e. the packages which can be in a packageinstance and therefore a job. Please make it clear that it is the name of the source package submitted as part of the job which will be used to match the regex.

Also, list exactly which fields can be matched (or convert the text entry box to a drop-down list of only the available fields), e.g. suite, architecture and build environment.

jamesbennet commented 11 years ago

The python regex syntax is a bit different to what you may expect - i.e."(acapela.-voices)" is valid, not "acapela-voices".

Right now we only support matching on name and vcs_uri, I think.