search

nicholasjng / nanobind-bazel

Bazel defs and rules for building Python projects with nanobind extensions.
Apache License 2.0
9 stars 1 forks source link

Visibility is not propagated #29

Closed aaliddell closed 6 months ago

aaliddell commented 6 months ago

When setting visibility on a nanobind_extension target, the resulting .so is not visible as requested due to the native.alias indirection. The visibility kwarg needs to be passed to the alias (and also probably the copy_files too):

The alias rule has its own visibility declaration. In all other respects, it behaves like the rule it references (e.g. testonly on the alias is ignored; the testonly-ness of the referenced rule is used instead) with some minor exceptions:

nicholasjng commented 6 months ago

Thanks for the report - this should be fixed in #30.