search

nicholasmallis / NicholasMallis-MADA-project

0 stars 2 forks source link

part 2 feedback #1

Open andreashandel opened 2 years ago

andreashandel commented 2 years ago

i can't run your Processing.Rmd script, produces errors. Same for project part 2.Rmd please fix errors so i can run everything.

the content in the html file looks like it's going in the right direction.

i suggest you start moving toward the project structure where main file contains content roughly similar to a research paper, and supplementary file contains all the remaining details/results. some other output can stay in places where it's produced, e.g., during exploration.

nicholasmallis commented 2 years ago

Hi Dr. Handel,

Thanks for getting in touch and letting me know. Sorry that it didn't work. So when you try to run the Rmd that produces the html output it doesn't work at all? What errors is it producing? I just deleted the folder from my desktop and re cloned the repo and it worked fine when I ran it. There were some warnings in red but the code still worked fine and everything seems to be behaving as it should.

I plan to get it in more of a report style soon. Based on the prompt, I thought that this might be easiest for you to look through (if it worked)

Thanks and sorry again for the confusion.

Nicholas

On Thu, Oct 14, 2021 at 5:59 PM Andreas Handel @.***> wrote:

i can't run your Processing.Rmd script, produces errors. Same for project part 2.Rmd please fix errors so i can run everything.

the content in the html file looks like it's going in the right direction.

i suggest you start moving toward the project structure where main file contains content roughly similar to a research paper, and supplementary file contains all the remaining details/results. some other output can stay in places where it's produced, e.g., during exploration.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicholasmallis/NicholasMallis-MADA-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5Y2ZLUT2PEPAKTXGXRTDLUG5HFHANCNFSM5GAUOZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com

nicholasmallis commented 2 years ago

Hi Dr. Handel,

I've been working on remedying the issue this morning. Were the errors you got due to packages not being installed?

I cloned it on Ishaan's computer and reran things and the only errors I got were for packages that aren't installed. I used the code below so the packages would install as they are loaded. I also rewrote the code for the data merge, but used several steps this time to make sure it worked. Before, I was using a function for the merge.

Anyways, let me know if you're seeing any other issues/errors and I will try and get this sorted out as soon as I can. I've recloned it a few times on my computer and it keeps working fine. Sorry again for the confusion.

Nicholas

the following code loads different packages and also installs them as

needed#if they aren't already installed mypackages<-c("readr", "plyr", "dplyr", "here", "tidyverse", "gridExtra", "tidyr", "gridExtra", "robustbase", "usmap", "ggplot2" ) for (p in mypackages){ if(!require(p, character.only = TRUE)){ install.packages(p) library(p, character.only = TRUE) } }

On Thu, Oct 14, 2021 at 10:33 PM Nicholas Mallis < @.***> wrote:

Hi Dr. Handel,

Thanks for getting in touch and letting me know. Sorry that it didn't work. So when you try to run the Rmd that produces the html output it doesn't work at all? What errors is it producing? I just deleted the folder from my desktop and re cloned the repo and it worked fine when I ran it. There were some warnings in red but the code still worked fine and everything seems to be behaving as it should.

I plan to get it in more of a report style soon. Based on the prompt, I thought that this might be easiest for you to look through (if it worked)

Thanks and sorry again for the confusion.

Nicholas

On Thu, Oct 14, 2021 at 5:59 PM Andreas Handel @.***> wrote:

i can't run your Processing.Rmd script, produces errors. Same for project part 2.Rmd please fix errors so i can run everything.

the content in the html file looks like it's going in the right direction.

i suggest you start moving toward the project structure where main file contains content roughly similar to a research paper, and supplementary file contains all the remaining details/results. some other output can stay in places where it's produced, e.g., during exploration.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nicholasmallis/NicholasMallis-MADA-project/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5Y2ZLUT2PEPAKTXGXRTDLUG5HFHANCNFSM5GAUOZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com

andreashandel commented 2 years ago

My workflow: I clone your repo, open project in Rstudio, go the files and either source or knit them.

Trying to run/source processingscript.R produces error in this line: ed$FIPS.Code <- as.numeric(ed$FIPS.Code)

Trying to knit Processing.Rmd produces this error: Quitting from lines 98-117 (Processing.Rmd) Error in [.data.frame(ed, myvars2) : undefined columns selected Calls: ... withCallingHandlers -> withVisible -> eval -> eval -> [ -> [.data.frame

I didn't try to run any others. Make sure each R script fully runs without errors when being sourced, and each Rmd file fully runs when being knit.

nicholasmallis commented 2 years ago

Thanks so much for the response and for letting me know where the issues showed up. I will pick them apart and get these errors cleared. Sorry!

On Thu, Oct 21, 2021 at 12:24 PM Andreas Handel @.***> wrote:

My workflow: I clone your repo, open project in Rstudio, go the files and either source or knit them.

Trying to run/source processingscript.R produces error in this line: ed$FIPS.Code <- as.numeric(ed$FIPS.Code)

Trying to knit Processing.Rmd produces this error: Quitting from lines 98-117 (Processing.Rmd) Error in [.data.frame(ed, myvars2) : undefined columns selected Calls: ... withCallingHandlers -> withVisible -> eval -> eval -> [ -> [.data.frame

I didn't try to run any others. Make sure each R script fully runs without errors when being sourced, and each Rmd file fully runs when being knit.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nicholasmallis/NicholasMallis-MADA-project/issues/1#issuecomment-948777331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5Y2ZMORHQ6PXWCFURC6S3UIA5FRANCNFSM5GAUOZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com

nicholasmallis commented 2 years ago

I still couldn't get R to produce any errors, but I reworked things a bit so hopefully you won't get any errors either now. I also did away with one of the scripts so now the only two materials for part two are Project Part 2.rmd and Processing_Exploration.rmd. I really hope it works this time. Like last time, I deleted it completely from my computer, re-cloned and reran everything and it knitted just fine. I recommend knitting Project Part 2.rmd.

Let me know if it still doesn't work and I'll try again.

Thank you, Nicholas

On Thu, Oct 21, 2021 at 12:45 PM Nicholas Mallis < @.***> wrote:

Thanks so much for the response and for letting me know where the issues showed up. I will pick them apart and get these errors cleared. Sorry!

On Thu, Oct 21, 2021 at 12:24 PM Andreas Handel @.***> wrote:

My workflow: I clone your repo, open project in Rstudio, go the files and either source or knit them.

Trying to run/source processingscript.R produces error in this line: ed$FIPS.Code <- as.numeric(ed$FIPS.Code)

Trying to knit Processing.Rmd produces this error: Quitting from lines 98-117 (Processing.Rmd) Error in [.data.frame(ed, myvars2) : undefined columns selected Calls: ... withCallingHandlers -> withVisible -> eval -> eval -> [ -> [.data.frame

I didn't try to run any others. Make sure each R script fully runs without errors when being sourced, and each Rmd file fully runs when being knit.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nicholasmallis/NicholasMallis-MADA-project/issues/1#issuecomment-948777331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5Y2ZMORHQ6PXWCFURC6S3UIA5FRANCNFSM5GAUOZQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com

-- Nicholas Mallis

www.nicholasmallis.com facebook.com/nicholasmallis instagram.com/nicholasmallis n http://bandcamp.com/nicholasmallisicholasmallis.bandcamp.com