Tournaments - Finished

[GoogleCodeExporter]

Do you think that a FFA should say finished in the Tournaments page if the 
tour is not locked?  Currently it will say finished if there are no 
unfinished scheduled matches.  I recommend that it only say finished if 
the tour is locked.

Original issue reported on code.google.com by funnyfin...@hotmail.com on 16 Jul 2009 at 1:38

[GoogleCodeExporter]

Good question. Lets debate it.
Maybe the finished condition should be if the tour is either locked OR a match 
exists
in the tour of round type = RT_FINAL and has been played?

Original comment by nicholas...@gmail.com on 16 Jul 2009 at 1:52

[GoogleCodeExporter]

I have not done much with the other types yet.  But it sounds good.  My first 
thought is well if RT_FINAL has been played, the admin should then lock it, but 
showing finished would let the admin know when to lock it.

Original comment by funnyfin...@hotmail.com on 16 Jul 2009 at 3:04

[GoogleCodeExporter]

How about outputting three different statuses?
Finished: When/if RT_FINAL has been played
Locked: When locked
<some name>: When all matches have been played

Original comment by Nimda...@gmail.com on 16 Jul 2009 at 5:17

[GoogleCodeExporter]

Well the gives me an idea:

Would it be easy to say what round has been finished?

Finished
Locked
Final Round Completed, Round 2 Completed, Round 1 completed, etc?

Original comment by funnyfin...@hotmail.com on 16 Jul 2009 at 5:24

[GoogleCodeExporter]

Yeah it's kind of easy, but takes a LOT of mysql queries to do it.

Original comment by Nimda...@gmail.com on 16 Jul 2009 at 6:10

[GoogleCodeExporter]

I think just go with

Finished
Locked

The third case I am not sure you need a different name then just empty.  I mean 
whether it is scheduled or not, another match is expected to be played if it is 
not 
locked.

If you want a third statement it could be In Progress.  But even if there is a 
scheduled match you could still go with In Progress.

Original comment by funnyfin...@hotmail.com on 16 Jul 2009 at 6:17

[GoogleCodeExporter]

OK. We'll stick with those two then.

Original comment by Nimda...@gmail.com on 16 Jul 2009 at 6:18

[GoogleCodeExporter]

Hmm.
What about Round Robin tours? There the tournament may end when everyone has 
played
each other. There is not necessarily a final match - only ordinary matches. In 
such
case when all matches have been played the tour should be marked finished, just 
as 
"finished" is defined atm.

Original comment by Nimda...@gmail.com on 16 Jul 2009 at 7:37

[GoogleCodeExporter]

Yeah if round robin and all matches complete, then finished.

Only tour that would keep going would be an FFA and would stop with a final.

Sounds good.

Original comment by funnyfin...@hotmail.com on 16 Jul 2009 at 8:20

[GoogleCodeExporter]

Just wanted to say that this sounds like a good idea to me.  FABBL only plays 
FFAs
because of our league structure, with coaches scheduling and creating their own
match-ups on the fly during a two-month period leading up to the playoffs -- 
league
size both in numbers and geography prevents any formal regular-season schedule 
from
being set in advance -- at which time I schedule playoff rounds based on 
seeding,
through to the finals.  So far, I've been putting in a match-up between two of 
my own
teams, which will of course never be played, just to prevent it from reading
"Finished" if all the other currently created pairings have been played. Once 
the
playoffs are done, I delete that "fake" pairing of my own teams; certainly not 
a big
deal, but not having to bother with that would be nice, and have a "lock" option
would be good as I have had coaches mess up and add new pairings to past, 
finished
tournaments by mistake.

Original comment by lahat...@gmail.com on 17 Jul 2009 at 9:05

[GoogleCodeExporter]

Done in r185.

Original comment by nicholas...@gmail.com on 17 Jul 2009 at 10:36

[GoogleCodeExporter]

Mike, locking has already been implemented in a past revision.

Original comment by nicholas...@gmail.com on 17 Jul 2009 at 10:36

[GoogleCodeExporter]

Original comment by nicholas...@gmail.com on 17 Jul 2009 at 10:36

• Changed state: Fixed

[GoogleCodeExporter]

I don't see that this is actually fixed.  My FFA tour still shows finished.

Original comment by funnyfin...@hotmail.com on 17 Jul 2009 at 12:17

• Changed state: Started

[GoogleCodeExporter]

Oh you know what , leegmgr puts in all of the tours as round 255.  I will check 
into
that.

Original comment by funnyfin...@hotmail.com on 17 Jul 2009 at 12:22

[GoogleCodeExporter]

Ok works good!

Original comment by funnyfin...@hotmail.com on 17 Jul 2009 at 12:29

[GoogleCodeExporter]

Has the final been played? Is the score NOT a tie?

Original comment by nicholas...@gmail.com on 17 Jul 2009 at 12:38

[GoogleCodeExporter]

Misunderstood you. Works now.

Original comment by Nimda...@gmail.com on 17 Jul 2009 at 12:47

• Changed state: Fixed