Renumber can duplicate numbers.

[GoogleCodeExporter]

Renumber lets you choose an existing player number that is not dead or
sold.  It is very important that it does not do that as it affects my
reporting.

Original issue reported on code.google.com by funnyfin...@hotmail.com on 21 Aug 2009 at 1:04

[GoogleCodeExporter]

What/how does it affect you?

I think it's a good idea that dead and sold players can keep their player 
numbers for
the record. I don't mind setting a limitation for alive players disallowing 
them to
use player numbers of already _alive_ players.

Original comment by Nimda...@gmail.com on 21 Aug 2009 at 7:23

[GoogleCodeExporter]

Hiring a journeyman with the same number as a MNG "regular" player is good when
playing tabletop, since you can use the same (already numbered) mini.

Original comment by blodae@gmail.com on 21 Aug 2009 at 12:31

[GoogleCodeExporter]

I just need to to work just like it does for hiring a new player.  If the 
number is 
actively being used by another player, if should not be available.

Specifically I used the player number from the BOTOCS report and match it up 
with no 
dead and not sold players on the team to get the player id and then I report on 
it.  
So if you have a duplicate, something will go wrong.  Probably the first player 
with 
the number will get reported for both.

Original comment by funnyfin...@hotmail.com on 21 Aug 2009 at 1:14

[GoogleCodeExporter]

Maybe you should be using player IDs as references instead?
Also, there is nothing wrong with your module taking over and renumbering 
players -
maybe that could solve it?

Original comment by Nimda...@gmail.com on 21 Aug 2009 at 1:30

[GoogleCodeExporter]

That is not possible.  The report does not give me player ids.  This is done 
correctly with hiring new players.  Think about it in real life.  You will 
never 
have duplicate roster numbers on the field.

Original comment by funnyfin...@hotmail.com on 21 Aug 2009 at 1:45

[GoogleCodeExporter]

I also noticed that you can renumber dead players.  I assume this to be true of 
sold
as well.

Original comment by funnyfin...@hotmail.com on 22 Aug 2009 at 10:58

[GoogleCodeExporter]

I'm going to have to take a stand here and say that this is quite useful for 
table
tops (I've consulted a handful of league I know), and that you'll have to be 
creative
finding a alternative way of solving this.

I suggest you adding an roster error/stop when a coach has done some illegal
numbering (write a number-checking routine). I think that would be an very good
solution for now - you can always, once you have time, try solving it 
differently.

Original comment by Nimda...@gmail.com on 31 Aug 2009 at 10:46

• Changed state: Done

[GoogleCodeExporter]

What about not allowing renumbering to a number of an existing uninjured player?

Original comment by funnyfin...@hotmail.com on 1 Sep 2009 at 2:40