Closed GoogleCodeExporter closed 9 years ago
I thought dumpoff_completions WAS "completions" ?
Original comment by Nimda...@gmail.com
on 3 Dec 2009 at 6:20
dumpoff_completions are completions done using the dump_off skill. They do
count as
SPP, which is why I asked that they be combined with pass_completions into just
completion.
Original comment by funnyfin...@hotmail.com
on 3 Dec 2009 at 12:55
Of course, don't know what I was thinking there :-).
Do necrosis check code.google regularly? Maybe we should mail him about it.
Original comment by Nimda...@gmail.com
on 3 Dec 2009 at 2:36
[deleted comment]
I went ahead and emailed him now.
Original comment by funnyfin...@hotmail.com
on 3 Dec 2009 at 3:31
Got the email
I think pass_completions already does contain all completions (least i thought
it did)
the dumpoff_completions stat only lists those which came about via use of the
skill
(purely for informational purposes, so you can see if it is a tactic used with a
certain player).
So basically all i think you want me to do is rename pass_commpletions to
completions
to maintain consistency with the default template
Original comment by necrosis...@googlemail.com
on 3 Dec 2009 at 3:43
pass_completions to completion even ;)
along with dropping the s on touchdowns and interceptions
Original comment by necrosis...@googlemail.com
on 3 Dec 2009 at 4:11
Committed this change, and updated the wiki think it is what was being asked
for, can
actually check it is all working atm
Original comment by necrosis...@googlemail.com
on 3 Dec 2009 at 4:31
Cool will try this out tonight!
I will delete my last match and report with EPS. If all works, then the site
will
continue with EPS.
Original comment by funnyfin...@hotmail.com
on 3 Dec 2009 at 4:37
BTW. Did you get the email when I cced necrosis.bb from here?
Original comment by funnyfin...@hotmail.com
on 3 Dec 2009 at 4:39
Looks good.
Original comment by funnyfin...@hotmail.com
on 3 Dec 2009 at 8:37
Original issue reported on code.google.com by
funnyfin...@hotmail.com
on 3 Dec 2009 at 4:21