nicholasmr / obblm

Automatically exported from code.google.com/p/obblm
26 stars 54 forks source link

some stats not matching between default and extra stats report. #310

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The default report has
  <completion>0</completion> 
  <interception>0</interception> 
  <casualties>0</casualties> 
  <touchdown>1</touchdown> 

Where the extra player stats has
  <pass_completions>0</pass_completions> 
  <dumpoff_completions>0</dumpoff_completions>
  <interceptions>0</interceptions> 
  <casualties>0</casualties>
  <touchdowns>1</touchdowns>

Can you make interceptions and touchdowns singular, while keeping 
pass_completions and dumpoff_completions, but making a another tag,
<completion> that has the sum of them?

This would make it easier to switch between EPS and default.

Original issue reported on code.google.com by funnyfin...@hotmail.com on 3 Dec 2009 at 4:21

GoogleCodeExporter commented 9 years ago
I thought dumpoff_completions WAS "completions" ?

Original comment by Nimda...@gmail.com on 3 Dec 2009 at 6:20

GoogleCodeExporter commented 9 years ago
dumpoff_completions are completions done using the dump_off skill.  They do 
count as
SPP, which is why I asked that they be combined with pass_completions into just
completion.

Original comment by funnyfin...@hotmail.com on 3 Dec 2009 at 12:55

GoogleCodeExporter commented 9 years ago
Of course, don't know what I was thinking there :-).
Do necrosis check code.google regularly?  Maybe we should mail him about it.

Original comment by Nimda...@gmail.com on 3 Dec 2009 at 2:36

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I went ahead and emailed him now.

Original comment by funnyfin...@hotmail.com on 3 Dec 2009 at 3:31

GoogleCodeExporter commented 9 years ago
Got the email

I think pass_completions already does contain all completions (least i thought 
it did)

the dumpoff_completions stat only lists those which came about via use of the 
skill
(purely for informational purposes, so you can see if it is a tactic used with a
certain player).

So basically all i think you want me to do is rename pass_commpletions to 
completions
to maintain consistency with the default template

Original comment by necrosis...@googlemail.com on 3 Dec 2009 at 3:43

GoogleCodeExporter commented 9 years ago
pass_completions to completion even ;)

along with dropping the s on touchdowns and interceptions

Original comment by necrosis...@googlemail.com on 3 Dec 2009 at 4:11

GoogleCodeExporter commented 9 years ago
Committed this change, and updated the wiki think it is what was being asked 
for, can
actually check it is all working atm

Original comment by necrosis...@googlemail.com on 3 Dec 2009 at 4:31

GoogleCodeExporter commented 9 years ago
Cool will try this out tonight!

I will delete my last match and report with EPS.  If all works, then the site 
will
continue with EPS.

Original comment by funnyfin...@hotmail.com on 3 Dec 2009 at 4:37

GoogleCodeExporter commented 9 years ago
BTW.  Did you get the email when I cced necrosis.bb from here?

Original comment by funnyfin...@hotmail.com on 3 Dec 2009 at 4:39

GoogleCodeExporter commented 9 years ago
Looks good.

Original comment by funnyfin...@hotmail.com on 3 Dec 2009 at 8:37