nicholasmr / obblm

Automatically exported from code.google.com/p/obblm
26 stars 54 forks source link

Core: Broken Neck Injury on Troll causes no Miss Next Game #440

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Play a game using the Cyanide game client 
2.Have a Troll get a broken neck (-1AG) injury
3.Upload the MatchReport.

What is the expected output? What do you see instead?
While a Troll (1AG), can't lose AG from a -1AG injury because their AG is 
already 1, the Troll still should Miss Next Game due to suffering the normal 
injury.

What version of the product are you using?
OBBLM on www.stuntyleeg.com

Original issue reported on code.google.com by furl...@gmail.com on 10 Jun 2010 at 6:25

GoogleCodeExporter commented 9 years ago
Have you had this injury on another player that could lose AG and did miss next 
game?  If you have, it may be a core issue.  If you are unsure, I can try some 
testing by doing this manually.

Original comment by funnyfin...@hotmail.com on 10 Jun 2010 at 4:10

GoogleCodeExporter commented 9 years ago
This is the first time we've had Broken Neck come up as an injury, so it could 
be a core issue. This is definitely something to run tests on, just because 
it's really hard to get this injury to come up on demand.

Original comment by furl...@gmail.com on 10 Jun 2010 at 6:33

GoogleCodeExporter commented 9 years ago
I went to your troll and tried to manually add AG injury and saved it.  It ends 
up saving to none.  Therefore, either Nicholas will fix this or I can add 
something that will have to check the current stat first and then give the SI 
or give a MNG.

Original comment by funnyfin...@hotmail.com on 10 Jun 2010 at 7:02

GoogleCodeExporter commented 9 years ago
Good to know. :) I suppose the SI should be marked on his record... even if it 
doesn't do anything.

Original comment by furl...@gmail.com on 10 Jun 2010 at 7:43

GoogleCodeExporter commented 9 years ago
BTW - email me.

Original comment by funnyfin...@hotmail.com on 10 Jun 2010 at 7:51

GoogleCodeExporter commented 9 years ago
This is a core issue actually.

Original comment by funnyfin...@hotmail.com on 20 Jun 2010 at 1:39

GoogleCodeExporter commented 9 years ago
Is it always the case, that when a player receives a characteristics decrease 
and cannot have it applied (because of already having 1 in that characteristic) 
that he instead receives a "bare" MNG?

Original comment by Nimda...@gmail.com on 20 Jun 2010 at 10:40

GoogleCodeExporter commented 9 years ago
Found this in the LRB:

-1 MA, ST, AG, and AV: Miss next game as above. In addition, record
the characteristic change on the team roster. However, no
characteristic may be reduced by more than 2 points or below a value
of 1. Any injuries that could reduce it further are ignored.

so I will add MNG injuries to players even when the decreases cannot be applied.

Original comment by Nimda...@gmail.com on 20 Jun 2010 at 10:49

GoogleCodeExporter commented 9 years ago
I think r724 resolves this. Instead of setting the inj to "none" when the lower 
char. limit has been broken, I now set it = MNG.

Please set the status to verified when you can confirm this works.

Original comment by Nimda...@gmail.com on 20 Jun 2010 at 11:40

GoogleCodeExporter commented 9 years ago
Furluge - If neither team has played a match since an there are no fires or 
hires you can delete the match and reupload to test this out.  You can also 
backup your DB before hand...

Original comment by funnyfin...@hotmail.com on 2 Aug 2010 at 11:02

GoogleCodeExporter commented 9 years ago
I'll go ahead and close this.

Original comment by funnyfin...@hotmail.com on 14 Aug 2010 at 8:07