search

nicholasmr / obblm

Automatically exported from code.google.com/p/obblm
26 stars 54 forks source link

Move global rules to local settings files #492

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Move the "Global rules" from settings.php to localsettings/settings_X.php

This will give leagues more customizability ie. letting the leagues have 
different variations of the obblm ruleset (init treasury, max players, jm, FF 
etc.).

Original issue reported on code.google.com by Nimda...@gmail.com on 21 Apr 2011 at 10:17

GoogleCodeExporter commented 9 years ago 
Good idea.

Original comment by funnyfin...@hotmail.com on 21 Apr 2011 at 1:14

GoogleCodeExporter commented 9 years ago 
how does this affect a synch all at this point and time.  If as now, it would 
synch all with the main rules or possibly the league yo are using.

Original comment by funnyfin...@hotmail.com on 22 Apr 2011 at 2:42

GoogleCodeExporter commented 9 years ago 
No change yet actually:
I have not moved the rest of the "Global rules", which are those which have 
ties to the SQL functions/procedures used in syncs etc (e.g. for team TV and 
such).
The ones I have moved for now are stuff like max players, init team treasury 
etc., which are purely used on a PHP level.

Also, r793 makes sure that leagues which do not have these settings moved to 
their local settings file will have the default values of settings_none.php, 
which are exactly those moved from the origional settings.php. I.e. William you 
should make sure that the "Global settings" from your old settings.php are in 
sync with the new localsettings/settings_none.php (which holds default values).

Original comment by Nimda...@gmail.com on 22 Apr 2011 at 6:45

GoogleCodeExporter commented 9 years ago 
r794

The remaining global settings are not migrated to the local settings file(s) 
but instead to game_data.php.

There are two reasons for this:
1) It's quite tedious to make this change because it requires much revising of 
the SQL core library code, which will not be done for 0.9.
2) They (the remaining global rules) have the same status as regular game data: 
Player costs, team rr costs etc. (from game_data.php) are as much game data as 
FF, apoth.cheerl. and assis. coach costs.

Original comment by Nimda...@gmail.com on 23 Apr 2011 at 10:07

GoogleCodeExporter commented 9 years ago

Original comment by Nimda...@gmail.com on 30 Apr 2011 at 9:32