nicholasmr / obblm

Automatically exported from code.google.com/p/obblm
26 stars 54 forks source link

More fancy Player page #60

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Since Im a frontend guy, I might as well use my expertise to make OBBLM
more userfriendly and 'nifty'. Therefore I have started working on a
'better' player info page.

This is the page Im talking about:
http://<site-root>/index.php?section=coachcorner&player_id=ID

I have a design Im working on, and I will commit it to my branch when I
have worked abit more on it. Then you guys can decide if you want it to go
into the trunk or not.

Any wishes/ideas you might have for this page are more than welcome.

Original issue reported on code.google.com by syko...@gmail.com on 30 Mar 2009 at 1:51

GoogleCodeExporter commented 9 years ago
Looking forward to seeing it !!
Thanks again for your work. It's greatly appreciated!

Original comment by Nimda...@gmail.com on 30 Mar 2009 at 4:51

GoogleCodeExporter commented 9 years ago
No wishes other than I would like to see the same information on the page :-).

Original comment by Nimda...@gmail.com on 30 Mar 2009 at 4:52

GoogleCodeExporter commented 9 years ago
I've got a mockup ready for you guys to see. Bear in mind that links on the 
page are
not meant to work, and that this is just the first draft. The CSS is a mess, 
and can
be cleaned up, also graphics can be improved (I've used a transparent png, that 
will
probably look silly in IE6).

Things I know I havent put in, are the winning, losing streaks and the bought 
date.

I have made the player image smaller, I see no reason to show a 250x250 image 
on the
page. If people upload images this big, maybe we can add a "click on image to 
see
larger version" feature.

Let me know what you think :)

Original comment by syko...@gmail.com on 12 Apr 2009 at 1:43

GoogleCodeExporter commented 9 years ago
Oh, forgot to mention, that "Hall of Fame" and "Wanted" is meant to be icons 
placed
to the right under the players number.

This is made and tested in FF3 only, since its a mockup I have not spend time
tweaking for IE6.

Original comment by syko...@gmail.com on 12 Apr 2009 at 1:46

GoogleCodeExporter commented 9 years ago
Please commit your work to your branch...

Original comment by Nimda...@gmail.com on 12 Apr 2009 at 1:58

GoogleCodeExporter commented 9 years ago
This is just a plain html mockup, I have not implemented anything yet.

... but I can see now that I completely forgot to say where the page can be 
seen. Whoups.

http://obblmdev.suneradich.dk/test/mockup.html

Original comment by syko...@gmail.com on 12 Apr 2009 at 2:02

GoogleCodeExporter commented 9 years ago
Nice!!! Keep up the good work.

Original comment by Nimda...@gmail.com on 12 Apr 2009 at 2:07

GoogleCodeExporter commented 9 years ago
If "Nice" is the only comment you have, then I'll get started implementing it 
in my
branch :)

Any other player-related information we want to show on the page?

Original comment by syko...@gmail.com on 12 Apr 2009 at 2:09

GoogleCodeExporter commented 9 years ago
Really, it's awesome. Go ahead. I might make it into 0.38, which I'll release 
next
week, if you hurry ;-). How do you generate that #7 image?

Original comment by Nimda...@gmail.com on 12 Apr 2009 at 2:15

GoogleCodeExporter commented 9 years ago
The number is just a H4 with a background image and the text "16", the #-char 
is part
of the image.

Original comment by syko...@gmail.com on 12 Apr 2009 at 2:35

GoogleCodeExporter commented 9 years ago
Looks very nice, Sune! :-D

/Daniel

Original comment by blodae@gmail.com on 14 Apr 2009 at 7:44

GoogleCodeExporter commented 9 years ago

Original comment by syko...@gmail.com on 15 Apr 2009 at 7:18

GoogleCodeExporter commented 9 years ago
I committed the work Ive done in my branch, but I sure could use someone with a 
PHP brain to make the "Upload 
player image" work in a popup window. Because the new layout is more compact, 
there is not room for the 
standard upload form, so it needs to be in a popup. I just couldnt make it work.

Also, I couldnt figure out how to properly merge all the new stuff from the 
trunk into my branch, so its only 
some of the new stuff in there.

Original comment by syko...@gmail.com on 22 Apr 2009 at 6:35

GoogleCodeExporter commented 9 years ago
Really all you need to do is call the same function in a new window?

I can't really help you on the merge, I haven't done that before, but some 
merges
have to be done with the help of evaluations from the developer.

Original comment by Nimda...@gmail.com on 22 Apr 2009 at 10:04

GoogleCodeExporter commented 9 years ago
Gah, I forgot to comment on the new player page possibility before... first off,
sykokaj, I really like the new design (based on looking at your mock-up link 
posted
above) and can't wait to see something like this go live. That said, I'd like to
offer a suggestion for you consideration.  I realize you deliberately shrunk the
picture window for an uploaded player image, but I'm trying to encourage my 
coaches
to post good pictures of their painted miniatures for each player, and having 
the
250x250 would be nice, if they actually do that.  I was thinking that if, going 
from
your mockup, the player's number/status/value were moved over to where the image
currently is, to the left of the name/position/team/attributes, then the picture
should fit on the far right, being able to still be 250x250 while still fitting
nicely within your sleek new design.  On a side note, swapping the two (and 
maybe
compromising on 200x200 for the image size) might allow room for the normal 
upload
form, too?

Original comment by lahat...@gmail.com on 25 Apr 2009 at 10:33

GoogleCodeExporter commented 9 years ago
I still think 250x250 is quite alot of space to use on an image of a player. I 
dont
know about other leagues, but in my league it is very few players who have 
painted
their player figures - and even fewer who have painted them in any detail and 
want
them shown online.

Also, using 250px just to show an image, when the space for the rest of the 
content
is 935px (1000px minus padding and borders) is alot. When I as a coach look at 
the
page, I want to see the player, his stats, his history, fun facts - and also an
image. But the image is by far the most important part.

But I might be a minority on this?

Original comment by syko...@gmail.com on 25 Apr 2009 at 10:51

GoogleCodeExporter commented 9 years ago
I find 250x250 quite fine too, but my for-argument also includes that the picbox
function used to generate the picture  and upload form for new pictures may 
thereby
still be used.

Original comment by Nimda...@gmail.com on 25 Apr 2009 at 11:23

GoogleCodeExporter commented 9 years ago
Certainly this is just a matter of personal preference, with no real right or 
wrong, 
and I can see where sykokaj is coming from.  However, even it people aren't 
posting 
pictures of painted miniatures, they can still post other pictures that are 
nice to 
see at a decent size.  An example from a team in my league is the players of 
the 
Caskow Celtic:

http://fabbl.net/tracker/index.php?section=coachcorner&player_id=376

The way I see it is that all of the game-relevant data for a player is already 
going 
to be seen first on the team page. If someone is then clicking deeper from the 
team 
page onto a particular player's page, they're going to be looking for more of 
the "fluff and color" type of stuff, which would include a nice picture.  
Additionally, in you mock-up you've already got over 200 pixels of space to the 
right of the player description, of which you're only using 100 pixels for the 
box 
with number, status, and value -- all of which could be considered 
game-relevant 
info.  If that info was moved to the far-left side where the 150x150 picture 
currently is in the mock-up, so that all game-relevant info was together on the 
left, then the player name/position/attribute/skills could be slid over 50 
pixels to 
the left; the player description could also then be slid 50 pixels to the left. 
 Now 
there would be more than 250 pixels of space on the far right for a 250x250 
image, 
you have all game-relevant info on the left and all "fluff" data (description 
and 
image) on the right, it all still fits neatly within the beautiful new style of 
the 
mock-up, and you can still use the same picture-upload mechanism that already 
exists 
elsewhere in the tracker.  I just see that as a win-win set-up, all the way 
around.

Original comment by lahat...@gmail.com on 27 Apr 2009 at 6:37

GoogleCodeExporter commented 9 years ago
I hear ya. I just dont find it logical to have the player image to the right. 
Look at
almost all rosters for real life teams

http://www.patriots.com/team/index.cfm?ac=playerbio&bio=33232
http://www.agf.co.dk/SpillerProfil.asp?id=803

Profile image to the left, information to the right.

I'll see if I can come up with sometime. Just annoying all your comments come 
now,
when I have implemented the first layout :)

Original comment by syko...@gmail.com on 27 Apr 2009 at 7:24

GoogleCodeExporter commented 9 years ago
Heh, I apologize again for the lateness in my comments; real life had pulled me 
away 
from watching OBBLM development for a week or so, and I'd forgot to check back 
in on 
this one right away when I did come back -- which I'd meant to do because, as 
I've 
said, I really do like the new design and would love to see it implemented 
(either 
way, whether it's per the original mock-up, or with my suggestions implemented).

You know, I do agree that aestethically speaking, the picture does look better 
on 
the left, like the real-life examples.  I'd just been trying to think of a 
design 
that would allow for the original picture size and upload mechanism while still 
fitting in the sleek new layout.  But I think I might've just though of a 
better 
one, then: have the 250x250 box be on the far left.  The 
name/position/attributes/skills already start to the left of the image, so move 
the 
stats and SPP over to the left of the image, too, flush with the name. Move the 
number/status/value section over next to the name/position/etc. group, to fill 
some 
of the space above the stats/SPP row, and then fill the far right with the 
description:

http://www.fabbl.net/images/mockup.jpg

Please forgive the crude nature of this image; I'm at work right now and am 
limited 
here to MS Paint for image editing. :-(  But it should illustrate my new idea; 
maybe 
the number/status/value gets flip-flopped with name/position/etc., I don't 
know.  
And obviously the actual description block would start a little further to the 
right 
and could come down next to the stats row.  This design does leave some blank 
space, 
but not too much more than was already in the original mock-up, plus the skills 
line 
can expand over the entirety of the stats row, and I can think of a bunch of 
players/positions which could fill the extra width with extra skills fairly 
quickly.

Again, this is just one guy's thought for a design compromise... do with it as 
you 
will. :-)

Original comment by lahat...@gmail.com on 27 Apr 2009 at 9:56

GoogleCodeExporter commented 9 years ago
I get the feeling Im quite alone on thinking 250x250 is too much for an image 
on this
page. :)

I have an idea for another solution, and I'll see if I can get time to make a 
mockup
soon.

Original comment by syko...@gmail.com on 27 Apr 2009 at 2:32

GoogleCodeExporter commented 9 years ago
How far are you on this?

Original comment by nicholas...@gmail.com on 22 May 2009 at 8:57

GoogleCodeExporter commented 9 years ago
Havent had time to redo the stuff I have already committed to my branch. (the 
150x150
picture and no upload functionality)

Original comment by syko...@gmail.com on 23 May 2009 at 10:15

GoogleCodeExporter commented 9 years ago

Original comment by Nimda...@gmail.com on 20 Jul 2009 at 12:07

GoogleCodeExporter commented 9 years ago

Original comment by Nimda...@gmail.com on 11 Oct 2009 at 5:13

GoogleCodeExporter commented 9 years ago
Sune, I don't mind you waiting until you have time, but I'll close this issue 
until
then. Please re-open it once you start your work.

Nicholas.

Original comment by Nimda...@gmail.com on 11 Oct 2009 at 9:58

GoogleCodeExporter commented 9 years ago
No worries. I still hope to have something for you soonish :)

Original comment by syko...@gmail.com on 12 Oct 2009 at 7:12