Closed GoogleCodeExporter closed 9 years ago
My thought with the green/yellow/red is exactly as you mention. Green = win,
yellow =
draw, red = loss.
I havent had a chance yet to see how it is implemented, but if a simple colored
dot
can cause confusion, maybe we should either
a) Add a letter to the graphics (though this sort goes against the original
purpose
of the idea).
b) Add a legend to make it clear what the dots mean.
No matter what, there should be a title/mouseover effect on the graphics with
the
word "Win", "Draw" or "Loss" depending on the color.
I'll take a look at how Nicholas implemented it and see if it needs tweaking to
make
it easier to understand.
The whole reason I wanted to add this was to make it easy and fast to
understand, not
at all the opposite.
Original comment by syko...@gmail.com
on 27 Apr 2009 at 2:08
The way it came out in my test environment was that wins were green like I
expected,
but draws were red and losses were yellow -- so I'd just assumed that you'd
designed
it that way. Since, as near as I could tell at just the quickest of first
glances,
the dots were just in particular ordered positions withinin a single .gif file,
I was
planning on just swapping the position of the red and the yellow within the
.gif...
and since I was editing the .gif anyway, I was also planning on adding the
letters
within the dots while I was at it (albeit in as subtle a manner as possible).
Original comment by lahat...@gmail.com
on 27 Apr 2009 at 3:23
I agree Sune. I've just used the functions you wrote like so (creating a fictive
temp. match property "result"):
$m->result = matchresult_icon((($m->is_draw) ? 'D' : (($m->winner ==
$team->team_id)
? 'W' : 'L')));
which should do the job correctly according to your function definition, maybe
it's
the CSS?
Original comment by Nimda...@gmail.com
on 27 Apr 2009 at 3:27
Found it, the CSS was quite simple. Fixed.
Original comment by Nimda...@gmail.com
on 27 Apr 2009 at 5:26
Original issue reported on code.google.com by
lahat...@gmail.com
on 27 Apr 2009 at 9:12