nicholasmr / obblm

Automatically exported from code.google.com/p/obblm
26 stars 54 forks source link

Simple question about color for game results icons #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This isn't really an issue, actually -- so sorry if I'm adding clutter 
when there was a better way to do this -- but I wasn't sure how else to 
reach sykokaj, and I was just curious as to the basis of the color 
selection on the new win-lose-draw icons (as far as which was which).  I'm 
figuring it's probably just an American vs. European difference. In 
America, we automatically associate a green-yellow-red color sequence with 
a traffic signal where green=go, yellow=caution, red=stop, with the lights 
appearing on the signal in that order.  Therefore, we'd tend to associate 
green=win, yellow=draw (a "middle" result), red=loss.  This also fits with 
the American listing of records in win-draw-loss order (in which a 7-2-1 
record is 7 wins, 2 draws, 1 loss), whereas my understanding is that 
European leagues reverse the losses and draws and put the draws at the end.

Again, this isn't really an issue -- it'll be simple enough for me to edit 
the .gif in the images folder -- but I was just curious so I thought I'd 
ask.

Original issue reported on code.google.com by lahat...@gmail.com on 27 Apr 2009 at 9:12

GoogleCodeExporter commented 9 years ago
My thought with the green/yellow/red is exactly as you mention. Green = win, 
yellow =
draw, red = loss.

I havent had a chance yet to see how it is implemented, but if a simple colored 
dot
can cause confusion, maybe we should either

a) Add a letter to the graphics (though this sort goes against the original 
purpose
of the idea).

b) Add a legend to make it clear what the dots mean.

No matter what, there should be a title/mouseover effect on the graphics with 
the
word "Win", "Draw" or "Loss" depending on the color.

I'll take a look at how Nicholas implemented it and see if it needs tweaking to 
make
it easier to understand. 

The whole reason I wanted to add this was to make it easy and fast to 
understand, not
at all the opposite.

Original comment by syko...@gmail.com on 27 Apr 2009 at 2:08

GoogleCodeExporter commented 9 years ago
The way it came out in my test environment was that wins were green like I 
expected,
but draws were red and losses were yellow -- so I'd just assumed that you'd 
designed
it that way. Since, as near as I could tell at just the quickest of first 
glances,
the dots were just in particular ordered positions withinin a single .gif file, 
I was
planning on just swapping the position of the red and the yellow within the 
.gif...
and since I was editing the .gif anyway, I was also planning on adding the 
letters
within the dots while I was at it (albeit in as subtle a manner as possible). 

Original comment by lahat...@gmail.com on 27 Apr 2009 at 3:23

GoogleCodeExporter commented 9 years ago
I agree Sune. I've just used the functions you wrote like so (creating a fictive
temp. match property "result"):

$m->result = matchresult_icon((($m->is_draw) ? 'D' : (($m->winner == 
$team->team_id)
? 'W' : 'L')));

which should do the job correctly according to your function definition, maybe 
it's
the CSS?

Original comment by Nimda...@gmail.com on 27 Apr 2009 at 3:27

GoogleCodeExporter commented 9 years ago
Found it, the CSS was quite simple. Fixed.

Original comment by Nimda...@gmail.com on 27 Apr 2009 at 5:26