search

nicholastng010601 / pe

0 stars 0 forks source link

Inconsistency in test cases #13

Open nicholastng010601 opened 10 months ago

nicholastng010601 commented 10 months ago

Screenshot 2023-11-17 at 5.20.44 PM.png

Filtering the list with special characters is expected to produce an error, as documented in the Test cases in DG. However, when I ran it on the application, the command was executed and no results were shown.

Screenshot 2023-11-17 at 5.19.59 PM.png

Screenshot 2023-11-17 at 5.20.15 PM.png

Screenshot 2023-11-17 at 5.20.34 PM.png

nus-pe-bot commented 9 months ago

Team's Response

filter results in an error message indicating the correct usage of the filter command:

image.png

filter @#$% with no such tags results in a no contacts found message:

image.png

The existing expected outcomes do match the specified example commands (respectively, and either/or). Filtering with special characters is not expected to result in an error message (the latter portion talks about a message but not an error message; error refers to the former portion, thus the word message is repeated). It isused as an example since it will always show a result of empty list.

However, it could be argued that these other examples could be split to enhance clarity in a future iteration of the documentation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As the dev said, it should be split to enhance clarity. As a reader, I would not know whether "filter " is expected to produce the error or "filter $#$" produces the error. As such, I believe this is in scope.