nicholastng010601 / pe

0 stars 0 forks source link

Index error message #3

Open nicholastng010601 opened 10 months ago

nicholastng010601 commented 10 months ago

When index 0 is written, the error message produced is "invalid command format". However, it does not accurately inform the user that the index given is invalid, but rather says the command format is invalid when it is valid. A better error message could be to tell the user that the index given is invalid.

Screenshot 2023-11-17 at 4.19.54 PM.png

soc-pe-bot commented 9 months ago

Team's Response

The UG specifically mentions

image.png

Therefore this is considered an invalid command. It is unlikely to hinder the user in any meaningful way.


More specific index error messages is covered as a planned enhancement.

image.png

If a bug matches an enhancement listed in the 'Appendix: Planned Enhancements' of the DG, that bug can be rejected (the tester should not have reported it at all).

https://nus-cs2103-ay2324s1.github.io/website/admin/tp-pe.html

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The information is all over the place and it is hard for users to follow. For the planned enhancements, it states that negative indexes produce the invalid command format, though 0 is technically not negative, while for their "about index numbers" screenshot, they state index 0 is not valid, but not negative numbers.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]