search

nicholaswilde / helm-charts

My collection of Helm charts.
https://artifacthub.io/packages/search?repo=nicholaswilde
Apache License 2.0
70 stars 32 forks source link

OliveTin Helm Chart - willing to collaborate? #57

Open jamesread opened 3 years ago

jamesread commented 3 years ago

Hi there @nicholaswilde , I just stumbled upon https://artifacthub.io/packages/helm/nicholaswilde/olivetin and https://github.com/nicholaswilde/docker-olivetin . I was surprised to see someone else packaging OliveTin, but also very pleased to see more people in the community using the project!

Nice job, looks like you've put in some good effort there and potentially solved some problems I was having with armv7 and arm64 builds. Thanks for taking the time to do this, and if you'd like to continue doing what you're doing on your own, please do continue to do so! :-)

I think users would really benefit from having fewer options for deployment - especially if they're the same / very similar. I'm not sure if you saw, but I already put up a Helm chart for OliveTin here; https://artifacthub.io/packages/helm/olivetin/olivetin . If there are some differences in how we approach things it probably would make sense to consider integrating those changes into the main project so everyone can benefit from them.

Would you be willing to join forces and collaborate, and potentially bring your improvements into the OliveTin project as a contributor?

I would happily make sure that your name is credited like other contributors, and would be very open to new ideas that you might have.

nicholaswilde commented 3 years ago

Hey @jamesread. Thanks for reaching out. All of my charts and images support all 3 amd64, arm64, and armv7 architectures. Instead of me bugging the developers to build the additional architectures, I take it upon myself to build and distribute them. Plus, I enjoy the challenge 😜.

I've also recommended that another developer (BabyBuddy) ask LinuxServer.io (LSIO) to host and maintain their official Docker image (they, too, support all 3 architectures). LSIO is just another option.

I agree with you in regards to having a limited amount of distributions available to the users. If we can get your image to support multi-arch, I can deprecate mine.

As for the chart, I see that yours does not support the values.yaml file to help support all of the GitOps people out there. I'm also involve with k8s@home that heavily use GitOps. It's a bit complicated, but my chart, as well as k8s@home's, support a common library that gives the user a ton of options when deploying to Kubernetes. If you want, we can deprecate my chart and yours and move it over to k8s@home and have the community support the chart (they know a TON about k8s).

Whichever way you'd like to go, I'd be happy to support you. If you want me to deprecate my image and chart, I will happily. If you want some help with having your Docker image support, I'd be glad to help. If you want to upgrade your Chart to support a common library, I can help out with that as well.

Just let me know how you'd like to proceed!

jamesread commented 3 years ago

Hey @nicholaswilde . Awesome-awesome.

RE amd64, arm64 and armv7: I would fully like to support them all - I'm currently doing golang binary builds for all 3, but I'm a podman user, and the release tooling I'm using - goreleaser, which has been generating the container images until now doesn't support podman well (it's a paid feature, eugh), and I had a nightmare and just gave up using docker - hence no arm64 and armv7 containers (ie, couldn't get them working - it's not that I didn't want them!)

Next step - I'm a huge fan of LSIO, and use several of their images myself in my homelab. Getting OliveTin containers adopted by the LSIO project with your support would be a huge step forward and frees me up RE packaging, to focus on code.

Note, the current container image had some really dumb problems, like no olivetin user, the wrong ID (1001), etc, so getting someone who builds these according to community standards would be much appreciated.

RE: Helm Chart - so, this is the first Helm chart I built myself, so for sure it's prone to errors and issues. I use k8s extensively, but mostly with operators and stuff - so I don't have a good feeling for what is normal with Helm. I've claimed the OliveTin organization on artifacthub.io (here: https://artifacthub.io/packages/helm/olivetin/olivetin) , would you be willing to contribute your values.yaml changes into https://github.com/OliveTin/OliveTin-HelmChart as PRs?

I'm not familiar with the k8s@home community, but that certainly sounds useful - going to bookmark that and research for myself! Again, very keen to follow community standards.

I hope that works out, and I didn't miss anything! Happy to communicate via GitHub issues, but also there is a Discord chat that you can find at http://olivetin.app if you'd like to chat more 1-on-1. Thanks!

jamesread commented 2 years ago

Hey @nicholaswilde , I hope all is well :-) I tried reaching out a few times via the k8s@home discord chat.

Just wanted to say, with the 2021-11-19 release of OliveTin, I'm now building for the 3 main arches we mentioned. It took a long time to work out how to do it reliability!

https://hub.docker.com/layers/jamesread/olivetin/latest/images/sha256-ad8a52bdc1a5f41a14cbf041f7bd5b2b7250489ff2190d4476a0c4866f0d0351?context=explore