search

nicholaswilde / helm-charts

My collection of Helm charts.
https://artifacthub.io/packages/search?repo=nicholaswilde
Apache License 2.0
70 stars 32 forks source link

common: envFrom not consumed #70

Open disconn3ct opened 2 years ago

disconn3ct commented 2 years ago

envFrom is documented here: https://github.com/nicholaswilde/helm-charts/blob/main/charts/common/values.yaml#L35

But in the templates, only env and secret are used: https://github.com/nicholaswilde/helm-charts/blob/main/charts/common/templates/lib/controller/_container.tpl#L19

For completeness, neither of those include envFrom: https://github.com/nicholaswilde/helm-charts/blob/main/charts/common/templates/_configmap.tpl#L11 https://github.com/nicholaswilde/helm-charts/blob/main/charts/common/templates/_secret.tpl#L12

johanneskastl commented 2 years ago

Will be fixed by #72

mmpetarpeshev commented 1 year ago

Is that fix released for hedgedoc chart?