search

nicholaswilde / helm-charts

My collection of Helm charts.
https://artifacthub.io/packages/search?repo=nicholaswilde
Apache License 2.0
70 stars 32 forks source link

[common] Added support for 'envFrom' values section as defined in values.yaml #72

Closed vladimir-babichev closed 2 years ago

vladimir-babichev commented 2 years ago

Description of the change

At the moment envFrom section defined in values.yaml doesn't honor user configured secrets/configmaps. This PR fixes it.

Benefits

Consumers can expose any arbitrary configmaps/secrets as env variables. It can be benefitial when used in combination with operators like external-secrets.

johanneskastl commented 2 years ago

This looks good to me and would really be useful, as one of my installs is broken due to envFrom not being supported.

So I would really see this merged... :-)

P.S.: I closed my duplicate PR, as I like @vladimir-babichev 's better.