search

nichyjt / pe

0 stars 0 forks source link

DG - Class diagrams do not adhere to CS2113 notation #11

Open nichyjt opened 1 year ago

nichyjt commented 1 year ago

Description

The class diagram notation and presentations do not adhere to what was taught in CS2113.

For example, under the Handling of User Input section:

image.png

  1. The (C) circle should not be there
  2. The access modifiers should not be symbols but rather "+,-,#" as per what was taught.

This is purely cosmetic, but the proper adherence to what was taught is possible with some modification to the PUML style config.

nus-pe-script commented 1 year ago

Team's Response

We believe that you may have attached the wrong image.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: I apologise for the wrong image.

Regardless, I think the issue still stands as I have provided enough context to show the source of the problems.

I explicitly highlighted the section

For example, under the Handling of User Input section:

And described the problem in words sufficiently

  1. The (C) circle should not be there
  2. The access modifiers should not be symbols but rather "+,-,#" as per what was taught.

This was the image that was supposed to be shown:

image.png

I hope this clarifies. Thank you!