search

nichyjt / pe

0 stars 0 forks source link

DG - Sequence diagrams do not adhere to CS2113 notation #12

Open nichyjt opened 1 year ago

nichyjt commented 1 year ago

Description

The footboxes for all the sequence diagrams should be removed to adhere to CS2113 taught notation. This doable by using a hide footbox command in the puml file.

image.png

nus-pe-bot commented 1 year ago

Team's Response

I don't think that footboxes are not allowed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

I disagree as no supporting documentation was brought up to justify the reponse.

I have supporting documentation regarding the proper syntax from the CS2113 website.

Notice how in all the example diagrams in the textbook that there are no terminating footboxes. This should be sufficiently clear to any reader that there is a difference between what was taught and what was shown in the diagram the team has generated.

It is not unreasonable to remove it as well - in the puml files the team just needs to add a hide footbox statement to their sequence diagrams.