nichyjt / pe

0 stars 0 forks source link

DG - Store sequence diagram missing return value #15

Open nichyjt opened 1 year ago

nichyjt commented 1 year ago

Description

The sequence diagram for store does not have the return line after a function is called. This does not maintain consistency with the earlier sequence diagrams as well.

image.png

nus-pe-script commented 1 year ago

Team's Response

Hi there, thank you so much for the feedback. However, it is important to note that sequence diagrams do not always have a return line. In the case of this sequence diagram not having the return line, this is because the function called does not return anything.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that minimal notation does not require activation bars and activation bars documented on the website.

However,

optional elements (e.g, activation bars, return arrows) may be omitted if the omission does not result in ambiguities or loss of relevant information.

I think that including the activation bar is ambiguous and a reader who understands UML would be expecting a returning dotted line.

It would be much clearer if the diagram simply did not have the activation bar to better adhere to the recommended minimal notation.