search

nichyjt / pe

0 stars 0 forks source link

`Graph` tangent graphs always throw a 'no amplitude' message. #4

Open nichyjt opened 1 year ago

nichyjt commented 1 year ago

Description

When graphing a tangent graph, the user guide dictates that a coefficient must be given to the trigo sign.

However, upon proper usage of the command, say 1*tan(x), the output tells me that the graph has no amplitude.

This is very misleading for users. Naturally, I tried to remove the amplitude and the command failed: tan(x).

This is frustrating for a user as the program seems to hint that there is no need for an amplitude for tan curves but it is required.

In fact, the message will be thrown for all proper inputs of tangent. Is this expected behaviour?

Screenshots

image.png

soc-se-bot commented 1 year ago

Team's Response

Based on properties of trigonometry graph, there is no amplitude for tangent and cotangent, but there is still a vertical stretch that takes the place of amplitude. Hence, the format of entering trigonometry tangent equations still follow the format of other two trigonometry equations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thank you for the response.

I think that the issue is in scope. The misleading message:

Psss...Tangent graph has no amplitude.

Will likely cause user behaviour that causes minor inconvenience to them. This was justified in my initial bug report.

A more fleshed out response explaining this in depth is under the issue severity section, but to summarise:

The misleading behaviour is plausible and can cause inconvenience to users in rare occasions. The impact of their misleading message goes beyond just cosmetics.

This misleading message could have been removed in v2.1, but was not.

I hope this clarifies. Thank you!

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** Thank you for the response. This issue is not purely cosmetic. It causes inconvenience to users. My main argument is that the behaviour of the program **is misleading**. The team did not justify the need for the message: > Psss...Tangent graph has no amplitude. This is not a particularly helpful message and is misleading to users. In some occasions, I showed how this may be misleading to the user and cause user frustration and wrong input: > However, upon proper usage of the command, say 1*tan(x), the output tells me that the graph has no amplitude. This is very misleading for users. Naturally, I tried to remove the amplitude and the command failed: tan(x). This is frustrating for a user as the program seems to hint that there is no need for an amplitude for tan curves but it is required. The team did not respond to this. I can accept that the equation format still requires an amplitude, but the main issue is with the misleading message that appears for all valid inputs of `tan` graphs which will cause minor inconvenience to users who are misled in the rare occasion. As such, the severity should be low. I hope this clarifies. Thank you!