nicinabox / boxcar

An admin interface for unRAID. Built with Sinatra and Bootstrap.
http://boxcar.nicinabox.com/
MIT License
10 stars 0 forks source link

if package version isn't specified do not use it in url #3

Closed hlarsen closed 11 years ago

hlarsen commented 11 years ago

trailing slash was being added when version wasn't specified, which would point to the wrong url.

nicinabox commented 11 years ago

Thanks!

I think this should actually be fixed in the route API to make the trailing slash optional:

get '/:name/?' do
  # ...
end

Same with /:name/:version.

hlarsen commented 11 years ago

word - using this an an excuse to learn ruby. looks like my fix breaks --persistent anyway; deferring to you on this one.

nicinabox commented 11 years ago

No problem! Contributions are always welcome. Just send a PR on the addons API. That should fix it.