search

nick-myers / azure-devops-board-cards

Azure DevOps Extension for printing work items to place on physical boards
MIT License
8 stars 4 forks source link

print screen cuts off #3

Closed Christ0phH closed 5 years ago

Christ0phH commented 5 years ago

When i have multiple lines of work items to print, the print screen cuts off the 3rd row when using A4 and horizontal view

nick-myers commented 5 years ago

Thank you @Christ0phH - do you mean A4 landscape? I can take a look at supporting this orientation. Is there a reason you're using landscape rather than portrait (is it a default)?

Are you able to provide a screenshot of the print preview so I can be sure I'm understanding your description correctly?

Christ0phH commented 5 years ago

Sorry for the misunderstanding. I'm using portrait mode where the items get cut off.

Sadly I can't provide a screenshot because i'm getting an error while uploading. ( i'll try later from my private machine)

nick-myers commented 5 years ago

board cards print preview chrome Here's a screenshot of what the print preview (and print out) look like for me, using Chrome.

nick-myers commented 5 years ago

@Christ0phH I've refactored the CSS to attempt to accommodate printing in an improved way, let me know how you get on?

Christ0phH commented 5 years ago

@Christ0phH I've refactored the CSS to attempt to accommodate printing in an improved way, let me know how you get on?

Hi @nick-myers, sadly my IT dept won't let me upload a picture here or on imgur or other platforms. #<3ITsecurity Can i mail you it instead, because that works ;)

Christ0phH commented 5 years ago

411121e9-dbe0-4b3b-9b48-a20e73d99b65

Hopefully this image will show the problem, took some time to get that image here ;)

nick-myers commented 5 years ago

Hi @Christ0phH thanks for the screenshot - shows me something is not working the way I expected it to.

I've just updated the extension and completely thrown out all the CSS, and replaced it with:

  1. https://github.com/cognitom/paper-css
  2. https://necolas.github.io/normalize.css/

And implemented "proper" paging (15 'cards' per page).

Would you give it another test drive and see if it's any better now?

Christ0phH commented 5 years ago

Hi @Christ0phH thanks for the screenshot - shows me something is not working the way I expected it to.

I've just updated the extension and completely thrown out all the CSS, and replaced it with:

  1. https://github.com/cognitom/paper-css
  2. https://necolas.github.io/normalize.css/

And implemented "proper" paging (15 'cards' per page).

Would you give it another test drive and see if it's any better now?

1.1.26? ... Could yout tag the issue with the proposed fixed versions?

nick-myers commented 5 years ago

@Christ0phH - I've tagged the issue with the 1.1.26 milestone - I need to commit the code to github, so once I've done that, and you've confirmed it's fixed the issue, I'll close this issue.

nick-myers commented 5 years ago

Pushed the changes to github. https://github.com/nick-myers/azure-devops-board-cards/commit/31fd90b1dbea49d9c8e275b441da461125c67e37

Christ0phH commented 5 years ago

Your fix has resolved the issue and i was able to print out the workitems without any cuts at the end of the page.

I look forward to any update you will do on this.