nick-shmyrev / improved-osk-gnome-ext

Improved On Screen Keyboard for Gnome Shell
https://extensions.gnome.org/extension/4413/improved-osk/
94 stars 29 forks source link

Enhance Gnome 43 Rewrite #34

Closed yfreund closed 1 year ago

yfreund commented 1 year ago

The main features of this pull request are:

If some of these changes are not wanted/welcome, the code can be cherry-picked, however the touch toggle requires some of the changes introduced in previous commits.

yfreund commented 1 year ago

Thanks for your feedback so far - I'm glad you approve of most of this code, and am happy to contribute 🙂

One thing I would suggest is to make "Ignore touch-input" and "Force touch-input" toggles mutually exclusive, i.e. toggle one setting off when the other one is toggled on, and vice versa.

I thought about it as well, and figured it might be better to let someone with more GTK experience adjust the toggles to be grayed out when the alternate one is toggled on. If this is a blocker for you, I'll try to see what I can do

yfreund commented 1 year ago

@nick-shmyrev The switches now get grayed out respectfully, and _ is replaced with _actor. Let me know if there's anything else you'd like changed before merging.

sughero commented 1 year ago

yiou've done a great job! No need to enable keyboard in accessinility menu.

Schermata del 2023-02-07 14-02-24

Touching the screen enables automatically keyboard in terminal is open. While typing elsewhere you still need to "activate" the keyboard (touching the OSK icon in the traybar) Schermata del 2023-02-07 14-08-13

Sometimes I use the tablet way with a pencil. It would be nice if "touch behaviour" occurred also when you use the pencil...

yfreund commented 1 year ago

Thanks for the feedback @sughero, I'm really glad this is further improving your experience! 😀

Touching the screen enables automatically keyboard in terminal is open. While typing elsewhere you still need to "activate" the keyboard (touching the OSK icon in the traybar)

Yes, that is expected under Wayland for some apps, and should probably be fixed upstream, though I might take a look at whether this could be improved after this initial change is merged.

Sometimes I use the tablet way with a pencil. It would be nice if "touch behaviour" occurred also when you use the pencil...

That sounds like an interesting improvement to consider in the future, though it sounds like something some users might argue against, so it might end up being an additional toggle (or would require replacing the toggle with a selection menu for the preferred behavior). I will ping you if I decide to give this a try, since I wouldn't be able to test this myself.

nick-shmyrev commented 1 year ago

@nick-shmyrev The switches now get grayed out respectfully, and _ is replaced with _actor. Let me know if there's anything else you'd like changed before merging.

@yfreund Everything looks good, just merged your changes. Thanks for the PR!