search

nick-shmyrev / improved-osk-gnome-ext

Improved On Screen Keyboard for Gnome Shell
https://extensions.gnome.org/extension/4413/improved-osk/
94 stars 30 forks source link

Gnome 44 support #38

Closed LeSnake04 closed 1 year ago

LeSnake04 commented 1 year ago

Gnome 44 will come out on the 22.03 this year and is already available in gnome OS. It would be great if this extension is available when it releases on popular distros

Fedora plans to release version 38 on the 25.04, so it would be great, if this is done by that date and the release of Ubuntu 23.04 and other distros.

Related: #30

nick-shmyrev commented 1 year ago

I prefer to add support for new Gnome versions only after they've been fully released. Beta versions might have bugs that will be fixed in the full release, and I'd rather not spend time figuring the root cause of the issue, and then overriding another piece of original OSK code that I would then have to either maintain, or remove/rewrite. Release versions might also introduce bugs which might make the OSK partially/fully unusable.

Right now, "Ctrl + Shift + [key]" key combinations in Fedora 38.beta (with gnome-shell 44.rc) aren't working in OSK. This might be fixed by the time Gnome 44 is released, or later, when Fedora 38 gets a full release. If not, I'll take a look.

If you want to be able to use this extension the day Fedora 38 ships, or test if out yourself right now, you can either manually add "44" to a list of supported versions in metadata.json file and proceed with the manual installation, or disable extension version validation check and install from extensions.gnome.org:

gsettings set org.gnome.shell disable-extension-version-validation true
LeSnake04 commented 1 year ago

I probably need to wait 1-2 weeks after the fedora release anyway until my other extensions update.

It will be more than enough if its available then. But I don't want to wait 3 months like I did the gnome 43 update.

I can test it on my endeavour os PC to help (I use kde there, so i dont care if my gnome conf breaks). Gnome 44 should arrive way earlier on arch.

nick-shmyrev commented 1 year ago

It will be more than enough if its available then. But I don't want to wait 3 months like I did the gnome 43 update.

I don't want to sound rude or harsh, but developing this extension is my hobby, not a job. I work on it when I have free time and am in the mood to do so.

You're more than welcome to make a PR that would add Gnome 44 support right now, and I'd be happy to merge it in, provided everything works as expected. There's a list of some of the test cases I usually check here.

Or, you can make your own fork, that's what I did when the previous maintainer abandoned their fork, and what the previous maintainer did when the original author abandoned the original version.

LeSnake04 commented 1 year ago

@nick-shmyrev Sorry, I didn't mean to be rude. I am mainly annoyed by the GNOME extension system, not by your work.

I love this extension and am so thankful for your work. I especially love the ability to use control shortcuts in tablet mode, but sadly don't know anything about gnome extensions or JS and already have too many side projects.

I can still test on gnome 44 to hopefully help you speed up the development process a bit.

Also, feel free to link to a donation page in the README, so users with some spare money can gift you some drinks as a thanks.

I don't like the frequency gnome devs are breaking extensions as well. Coming from KDE, I Know how much easier it is for users and devs when the DE doesn't block everything slightly outdated, though it likely still works. It looks like they even avoid changing stuff that might be used by plugins (judging by how many 1-2 year old panel plugins work great on modern versions), something gnome should start doing more. I have serious respect for extension Devs like you that are willing to take on that maintenance burden. Thanks for reading my rant.