search

nick-shmyrev / improved-osk-gnome-ext

Improved On Screen Keyboard for Gnome Shell
https://extensions.gnome.org/extension/4413/improved-osk/
94 stars 30 forks source link

Pt layout #47

Open gilbertorconde opened 1 year ago

gilbertorconde commented 1 year ago

Add extended pt layout

gilbertorconde commented 1 year ago

Greate :D did you look at my last commit? Because I noticed those issues right after my PR and fix those. Now I'm not in my computer but I'll check again asap

nick-shmyrev commented 1 year ago

Yep, I checked out the last commit on your PR. Perhaps that fix wasn't pushed upstream?

nick-shmyrev commented 1 year ago

Also, something that worries me is that now the "Hide" button placement is going to be inconsistent, i.e. it'll be in one place on the first 2 layers, and in a different place on the rest of the PT layers as well as all other language layouts. I understand why you wanted to move it to a different spot, but I'm a bit worried that having to remember where it is on different layers might get annoying. This is not necessarily a change request, but rather something to think about. In the end, you (and other people using PT layout) are going to have to live with it.

gilbertorconde commented 1 year ago

Also, something that worries me is that now the "Hide" button placement is going to be inconsistent, i.e. it'll be in one place on the first 2 layers, and in a different place on the rest of the PT layers as well as all other language layouts. I understand why you wanted to move it to a different spot, but I'm a bit worried that having to remember where it is on different layers might get annoying. This is not necessarily a change request, but rather something to think about. In the end, you (and other people using PT layout) are going to have to live with it.

You're right. I'll think about that as well