search

nick / react-native-carousel

Carousel component for react-native
MIT License
458 stars 107 forks source link

animate={false} does not work. #27

Open ibraheemabukhdair opened 8 years ago

ibraheemabukhdair commented 8 years ago

animate={false}, does not work. It automatically moves to the next slide on a click, and then when you click again, it transitions to the next slide even faster until it's moving between slides at 80mph.

yrokhlin commented 8 years ago

The problem seems to be with the _animateNextPage() function. this._setUpTimer() is being called at the end of the function, every time a page animated, leading to exponential increase in frequency.

Either set up a conditional there, or just remove it from _animateNextPage() to get it working-- I'm not 100% sure what intended behavior is here.

alubling commented 8 years ago

Ran into this same issue. It's actually just an extra call to _animateNextPage() towards the end of the '_onAnimationEnd'. It calls this._animateNextPage() again once the activePage has been reset, which should trigger an animation to the next page but it looks like it will run everytime, since onAnimationEnd() is triggered whenever onMomentumScrollEnd fires. Looks like there is a PR but hasn't been merged - https://github.com/nick/react-native-carousel/pull/26