nick / react-native-carousel

Carousel component for react-native
MIT License
458 stars 107 forks source link

Please remove peerDependencies from package.json #29

Open PublicParadise opened 8 years ago

PublicParadise commented 8 years ago

The current peerDependencies entry for package.json reads:

"peerDependencies": {
    "react-native": ">=0.4 <1.0"
  }

With that dependency list I am currently unable to install react-native-carousel with react-native-vector-icons and react-native version 0.16.0, because of https://github.com/npm/npm/issues/8854. react-native-vector-icons declares in its package.json these peerDependencies:

"peerDependencies": {
    "react-native": ">=0.4.0 || 0.5.0-rc1 || 0.6.0-rc || 0.7.0-rc || 0.7.0-rc.2 || 0.8.0-rc || 0.8.0-rc.2 || 0.9.0-rc || 0.10.0-rc || 0.11.0-rc || 0.12.0-rc || 0.13.0-rc || 0.14.0-rc || 0.15.0-rc || 0.16.0-rc || 0.17.0-rc"
  },

The issue reported in https://github.com/npm/npm/issues/8854 correctly complains about 0.16.0-rc not being matched by >=0.4 <1.0

I wonder: Is declaring peerDependencies list necessary at all? What does the author of this package want to express with a dependency list that accepts all version of react-native since 0.4 including future versions up to 1.0? Does that mean that 1.0.1 will not be supported any longer? Even >=0.4.0 could be dropped if you are willing to assume that nobody uses react-native versions before 4/20/2015 any longer.

Thank you in advance.