search

nick / react-native-carousel

Carousel component for react-native
MIT License
458 stars 107 forks source link

Updated new signature for scrollTo #35

Closed alinz closed 8 years ago

alinz commented 8 years ago

As of react-native 0.20 previous scrollTo has been deprecated.

alinz commented 8 years ago

@nick before either accepting or rejecting my PR, consider backward compatiblility. I think we need to either use peerDependecies or use if (React.version >= 20) { new syntax } else { old syntax }. this approach was mentioned by @skv-headless in here https://github.com/brentvatne/react-native-scrollable-tab-view/pull/158

Vani-gurnani commented 8 years ago

But this code will stop the animation of view :(

nick commented 8 years ago

Think this is now fixed